You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/10 18:38:35 UTC

[GitHub] [beam] fernando-wizeline opened a new pull request, #21800: sharding GCP IO tests from the javaPostCommit task

fernando-wizeline opened a new pull request, #21800:
URL: https://github.com/apache/beam/pull/21800

   Removing the job from the javaPostcommit task and adding its own task for GCP IO tests.
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: "addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "fixes #<ISSUE NUMBER>" instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r908741753


##########
build.gradle.kts:
##########
@@ -196,7 +196,9 @@ tasks.register("javaPreCommitPortabilityApi") {
 tasks.register("javaPostCommit") {
   dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit")
   dependsOn(":sdks:java:extensions:zetasketch:postCommit")
-  dependsOn(":sdks:java:io:google-cloud-platform:postCommit")
+  dependsOn(":sdks:java:io:debezium:integrationTest")

Review Comment:
   @damccorm will do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21800:
URL: https://github.com/apache/beam/pull/21800#issuecomment-1168916658

   Yep, I actually can now!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r908739699


##########
build.gradle.kts:
##########
@@ -196,7 +196,9 @@ tasks.register("javaPreCommitPortabilityApi") {
 tasks.register("javaPostCommit") {
   dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit")
   dependsOn(":sdks:java:extensions:zetasketch:postCommit")
-  dependsOn(":sdks:java:io:google-cloud-platform:postCommit")
+  dependsOn(":sdks:java:io:debezium:integrationTest")

Review Comment:
   Oh you're right - good catch, I thought that was part of breaking this apart, but it is not. @fernando-wizeline guessing that wasn't intentional?
   
   @Abacn want to put up a PR to remove those lines?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] fernando-wizeline commented on pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #21800:
URL: https://github.com/apache/beam/pull/21800#issuecomment-1168882084

   Hi @damccorm! Do you know who can help us to merge this one?
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm merged pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
damccorm merged PR #21800:
URL: https://github.com/apache/beam/pull/21800


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
kennknowles commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r897078130


##########
.test-infra/jenkins/job_PreCommit_Java_GCP_IO_Direct.groovy:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PrecommitJobBuilder
+
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
+    scope: this,
+    nameBase: 'Java',
+    gradleTask: ':sdks:java:io:google-cloud-platform:postCommit',
+    gradleSwitches: [
+      '-PdisableSpotlessCheck=true'
+    ], // spotless checked in separate pre-commit
+    timeoutMins: 120,
+    triggerPathPatterns: [
+      '^sdks/java/io/google-cloud-platform/.*$',
+      '^runners/direct-java/.*$',
+    ]
+    )
+builder.build {

Review Comment:
   Is this different from the other precommit builder defaults?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] fernando-wizeline commented on pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #21800:
URL: https://github.com/apache/beam/pull/21800#issuecomment-1168959464

   Nice!
   Thanks again @damccorm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] fernando-wizeline commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r897088782


##########
.test-infra/jenkins/job_PreCommit_Java_GCP_IO_Direct.groovy:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PrecommitJobBuilder
+
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
+    scope: this,
+    nameBase: 'Java',
+    gradleTask: ':sdks:java:io:google-cloud-platform:postCommit',
+    gradleSwitches: [
+      '-PdisableSpotlessCheck=true'
+    ], // spotless checked in separate pre-commit
+    timeoutMins: 120,
+    triggerPathPatterns: [
+      '^sdks/java/io/google-cloud-platform/.*$',
+      '^runners/direct-java/.*$',
+    ]
+    )
+builder.build {

Review Comment:
   Yeah, they are different. I added the paths to the direct runner and gcp io folders.
   Thanks Kenn!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] fernando-wizeline commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r908741081


##########
build.gradle.kts:
##########
@@ -196,7 +196,9 @@ tasks.register("javaPreCommitPortabilityApi") {
 tasks.register("javaPostCommit") {
   dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit")
   dependsOn(":sdks:java:extensions:zetasketch:postCommit")
-  dependsOn(":sdks:java:io:google-cloud-platform:postCommit")
+  dependsOn(":sdks:java:io:debezium:integrationTest")

Review Comment:
   Oh, this is so embarrassing, sorry.
   That is correct, it was not intentional.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21800:
URL: https://github.com/apache/beam/pull/21800#issuecomment-1152665710

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r908742976


##########
build.gradle.kts:
##########
@@ -196,7 +196,9 @@ tasks.register("javaPreCommitPortabilityApi") {
 tasks.register("javaPostCommit") {
   dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit")
   dependsOn(":sdks:java:extensions:zetasketch:postCommit")
-  dependsOn(":sdks:java:io:google-cloud-platform:postCommit")
+  dependsOn(":sdks:java:io:debezium:integrationTest")

Review Comment:
   No problem, I should've caught it too! Happy to quick approve/merge a pr to remove them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #21800:
URL: https://github.com/apache/beam/pull/21800#issuecomment-1156907932

   There a conflict caused by the other sharding PR, should be easy to fix up. Be sure to check spotless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
kennknowles commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r897077751


##########
.test-infra/jenkins/job_PreCommit_Java_GCP_IO_Direct.groovy:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PrecommitJobBuilder
+
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
+    scope: this,
+    nameBase: 'Java',
+    gradleTask: ':sdks:java:io:google-cloud-platform:postCommit',
+    gradleSwitches: [
+      '-PdisableSpotlessCheck=true'
+    ], // spotless checked in separate pre-commit
+    timeoutMins: 120,
+    triggerPathPatterns: [
+      '^sdks/java/io/google-cloud-platform/.*$',
+      '^runners/direct-java/.*$',

Review Comment:
   Remove this trigger path, since a change to the direct runner does not change the correctness of the IOs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r908729206


##########
build.gradle.kts:
##########
@@ -196,7 +196,9 @@ tasks.register("javaPreCommitPortabilityApi") {
 tasks.register("javaPostCommit") {
   dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit")
   dependsOn(":sdks:java:extensions:zetasketch:postCommit")
-  dependsOn(":sdks:java:io:google-cloud-platform:postCommit")
+  dependsOn(":sdks:java:io:debezium:integrationTest")

Review Comment:
   These line were removed in #21804 but added back in this PR. Sounds like a rebase issue. Should do a rebase instead of merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r908742976


##########
build.gradle.kts:
##########
@@ -196,7 +196,9 @@ tasks.register("javaPreCommitPortabilityApi") {
 tasks.register("javaPostCommit") {
   dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit")
   dependsOn(":sdks:java:extensions:zetasketch:postCommit")
-  dependsOn(":sdks:java:io:google-cloud-platform:postCommit")
+  dependsOn(":sdks:java:io:debezium:integrationTest")

Review Comment:
   No problem, I should've caught it too! Thanks Yi



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] fernando-wizeline commented on a diff in pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #21800:
URL: https://github.com/apache/beam/pull/21800#discussion_r897088076


##########
.test-infra/jenkins/job_PreCommit_Java_GCP_IO_Direct.groovy:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PrecommitJobBuilder
+
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
+    scope: this,
+    nameBase: 'Java',
+    gradleTask: ':sdks:java:io:google-cloud-platform:postCommit',
+    gradleSwitches: [
+      '-PdisableSpotlessCheck=true'
+    ], // spotless checked in separate pre-commit
+    timeoutMins: 120,
+    triggerPathPatterns: [
+      '^sdks/java/io/google-cloud-platform/.*$',
+      '^runners/direct-java/.*$',

Review Comment:
   Will do!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21800: sharding GCP IO tests from the javaPostCommit task

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21800:
URL: https://github.com/apache/beam/pull/21800#issuecomment-1152665707

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org