[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #104: [MRELEASE-1078] Conventional commits

[GitBox <gi...@apache.org>]

nielsbasjes commented on code in PR #104:
URL: https://github.com/apache/maven-release/pull/104#discussion_r927361884


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/config/PropertiesReleaseDescriptorStore.java:
##########
@@ -271,7 +271,7 @@ public void write( BuilderReleaseDescriptor config, File file )
         }
         if ( config.getProjectVersionPolicyConfig() != null )
         {
-            properties.setProperty( "projectVersionPolicyConfig", config.getProjectVersionPolicyConfig() );
+            properties.setProperty( "projectVersionPolicyConfig", config.getProjectVersionPolicyConfig().toString() );

Review Comment:
   I did that as a workaround to the fact that the `Properties::setProperty` only supports setting a `String`. Note that this code is used to read/write it to a file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org