You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Krisztian Horvath <kr...@sequenceiq.com> on 2014/09/17 14:07:07 UTC
Review Request 25731: Google Compute Cloud public hostname resolution
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25731/
-----------------------------------------------------------
Review request for Ambari and Mahadev Konar.
Bugs: AMBARI-7357
https://issues.apache.org/jira/browse/AMBARI-7357
Repository: ambari
Description
-------
AWS provides a metadata service which the agent can use to resolve and set the host's public hostname. Similar to that GCC provides almost the same metadata service, the only difference is that at GCC there is no public hostname only public IP. We could use this IP as the public hostname as the hosts are not reachable any other way outside the VPC.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145
Diff: https://reviews.apache.org/r/25731/diff/
Testing
-------
Tested on AWS and GCC
Thanks,
Krisztian Horvath
Re: Review Request 25731: Google Compute Cloud public hostname
resolution
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25731/#review54205
-----------------------------------------------------------
This seems like a good fix to make "quick links" work out of the box when the cluster is deployed on GCE.
However, as mentioned in the corresponding JIRA, this patch has a side effect of showing IP addresses, rather than hostnames, in the Hosts page and Host Detail page in Ambari Web UI. This is a result of these pages using public hostnames rather than internal hostnames as they should.
We ideally change the Hosts and Host Detail pages to show internal hostname instead, but this is sort of a big UI change for those who are used to the current behavior and would be a surprise.
This level of change in the UI behavior is justified for the 2.0 release, so I say hold off on committing this until the 1.7.0 branch is cut (and we'll commit the accompanying UI changes together).
Thoughts?
- Yusaku Sako
On Sept. 17, 2014, 12:11 p.m., Krisztian Horvath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25731/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 12:11 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Yusaku Sako.
>
>
> Bugs: AMBARI-7357
> https://issues.apache.org/jira/browse/AMBARI-7357
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AWS provides a metadata service which the agent can use to resolve and set the host's public hostname. Similar to that GCC provides almost the same metadata service, the only difference is that at GCC there is no public hostname only public IP. We could use this IP as the public hostname as the hosts are not reachable any other way outside the VPC.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145
>
> Diff: https://reviews.apache.org/r/25731/diff/
>
>
> Testing
> -------
>
> Tested on AWS and GCC
>
>
> Thanks,
>
> Krisztian Horvath
>
>
Re: Review Request 25731: Google Compute Cloud public hostname
resolution
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Sept. 23, 2014, 1:07 a.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/hostname.py, line 91
> > <https://reviews.apache.org/r/25731/diff/1/?file=692531#file692531line91>
> >
> > To make it clear that this is actually google and not someone's personal box, I suggest using http://metadata/computeMetadata/v1/
> > This is a nice improvement to have on the site
http://metadata.google.internal/computeMetadata/v1/
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25731/#review54226
-----------------------------------------------------------
On Sept. 17, 2014, 12:11 p.m., Krisztian Horvath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25731/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 12:11 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Yusaku Sako.
>
>
> Bugs: AMBARI-7357
> https://issues.apache.org/jira/browse/AMBARI-7357
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AWS provides a metadata service which the agent can use to resolve and set the host's public hostname. Similar to that GCC provides almost the same metadata service, the only difference is that at GCC there is no public hostname only public IP. We could use this IP as the public hostname as the hosts are not reachable any other way outside the VPC.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145
>
> Diff: https://reviews.apache.org/r/25731/diff/
>
>
> Testing
> -------
>
> Tested on AWS and GCC
>
>
> Thanks,
>
> Krisztian Horvath
>
>
Re: Review Request 25731: Google Compute Cloud public hostname
resolution
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25731/#review54226
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/hostname.py
<https://reviews.apache.org/r/25731/#comment94231>
To make it clear that this is actually google and not someone's personal box, I suggest using http://metadata/computeMetadata/v1/
This is a nice improvement to have on the site
- Alejandro Fernandez
On Sept. 17, 2014, 12:11 p.m., Krisztian Horvath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25731/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 12:11 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Yusaku Sako.
>
>
> Bugs: AMBARI-7357
> https://issues.apache.org/jira/browse/AMBARI-7357
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AWS provides a metadata service which the agent can use to resolve and set the host's public hostname. Similar to that GCC provides almost the same metadata service, the only difference is that at GCC there is no public hostname only public IP. We could use this IP as the public hostname as the hosts are not reachable any other way outside the VPC.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145
>
> Diff: https://reviews.apache.org/r/25731/diff/
>
>
> Testing
> -------
>
> Tested on AWS and GCC
>
>
> Thanks,
>
> Krisztian Horvath
>
>
Re: Review Request 25731: Google Compute Cloud public hostname
resolution
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25731/#review54196
-----------------------------------------------------------
Looks like its GCE and not GCC: https://cloud.google.com/products/compute-engine/. Can we change that in the patch? Other than that it looks good.
- Mahadev Konar
On Sept. 17, 2014, 12:11 p.m., Krisztian Horvath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25731/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 12:11 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Yusaku Sako.
>
>
> Bugs: AMBARI-7357
> https://issues.apache.org/jira/browse/AMBARI-7357
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AWS provides a metadata service which the agent can use to resolve and set the host's public hostname. Similar to that GCC provides almost the same metadata service, the only difference is that at GCC there is no public hostname only public IP. We could use this IP as the public hostname as the hosts are not reachable any other way outside the VPC.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145
>
> Diff: https://reviews.apache.org/r/25731/diff/
>
>
> Testing
> -------
>
> Tested on AWS and GCC
>
>
> Thanks,
>
> Krisztian Horvath
>
>
Re: Review Request 25731: Google Compute Cloud public hostname
resolution
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25731/#review54197
-----------------------------------------------------------
Also please refresh the reviewboard with the latest patch.
- Mahadev Konar
On Sept. 17, 2014, 12:11 p.m., Krisztian Horvath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25731/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 12:11 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Yusaku Sako.
>
>
> Bugs: AMBARI-7357
> https://issues.apache.org/jira/browse/AMBARI-7357
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AWS provides a metadata service which the agent can use to resolve and set the host's public hostname. Similar to that GCC provides almost the same metadata service, the only difference is that at GCC there is no public hostname only public IP. We could use this IP as the public hostname as the hosts are not reachable any other way outside the VPC.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145
>
> Diff: https://reviews.apache.org/r/25731/diff/
>
>
> Testing
> -------
>
> Tested on AWS and GCC
>
>
> Thanks,
>
> Krisztian Horvath
>
>
Re: Review Request 25731: Google Compute Cloud public hostname
resolution
Posted by Krisztian Horvath <kr...@sequenceiq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25731/
-----------------------------------------------------------
(Updated Sept. 17, 2014, 12:11 p.m.)
Review request for Ambari, Mahadev Konar and Yusaku Sako.
Bugs: AMBARI-7357
https://issues.apache.org/jira/browse/AMBARI-7357
Repository: ambari
Description
-------
AWS provides a metadata service which the agent can use to resolve and set the host's public hostname. Similar to that GCC provides almost the same metadata service, the only difference is that at GCC there is no public hostname only public IP. We could use this IP as the public hostname as the hosts are not reachable any other way outside the VPC.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145
Diff: https://reviews.apache.org/r/25731/diff/
Testing
-------
Tested on AWS and GCC
Thanks,
Krisztian Horvath