You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/05 13:21:25 UTC
[GitHub] [incubator-doris] jackwener commented on a change in pull request #7309: [Enhancement] Improve the chapter on debugging FE in doc.
jackwener commented on a change in pull request #7309:
URL: https://github.com/apache/incubator-doris/pull/7309#discussion_r762560952
##########
File path: docs/zh-CN/developer-guide/fe-idea-dev.md
##########
@@ -37,9 +37,22 @@ JDK1.8+, IntelliJ IDEA
3. 如果仅进行fe开发而没有编译过thirdparty，则需要安装thrift，并将thrift 复制或者连接到 `thirdparty/installed/bin` 目录下
安装 `thrift` 0.13.0 版本(注意：`Doris` 0.15 和最新的版本基于 `thrift` 0.13.0 构建, 之前的版本依然使用`thrift` 0.9.3 构建)
+
+ Windows:
+ ① 下载：`http://archive.apache.org/dist/thrift/0.13.0/thrift-0.13.0.exe`
Review comment:
You may be not familiar with markdown.
It's better use 1. instead of ①.
```suggestion
1. 下载：`http://archive.apache.org/dist/thrift/0.13.0/thrift-0.13.0.exe`
```
##########
File path: docs/zh-CN/developer-guide/fe-idea-dev.md
##########
@@ -37,9 +37,22 @@ JDK1.8+, IntelliJ IDEA
3. 如果仅进行fe开发而没有编译过thirdparty，则需要安装thrift，并将thrift 复制或者连接到 `thirdparty/installed/bin` 目录下
安装 `thrift` 0.13.0 版本(注意：`Doris` 0.15 和最新的版本基于 `thrift` 0.13.0 构建, 之前的版本依然使用`thrift` 0.9.3 构建)
+
+ Windows:
+ ① 下载：`http://archive.apache.org/dist/thrift/0.13.0/thrift-0.13.0.exe`
+ ② 拷贝：将文件拷贝至./thirdparty/installed/bin
+
+ MacOS:
+ ① 下载：`brew install thrift@0.13.0`
+ ② 建立软链接：
+ mkdir -p ./thirdparty/installed/bin
Review comment:
add double \` \`, it can show `like this`.
The following is same.
##########
File path: docs/zh-CN/developer-guide/fe-idea-dev.md
##########
@@ -37,9 +37,22 @@ JDK1.8+, IntelliJ IDEA
3. 如果仅进行fe开发而没有编译过thirdparty，则需要安装thrift，并将thrift 复制或者连接到 `thirdparty/installed/bin` 目录下
安装 `thrift` 0.13.0 版本(注意：`Doris` 0.15 和最新的版本基于 `thrift` 0.13.0 构建, 之前的版本依然使用`thrift` 0.9.3 构建)
+
+ Windows:
+ ① 下载：`http://archive.apache.org/dist/thrift/0.13.0/thrift-0.13.0.exe`
Review comment:
The following also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org