You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ji...@apache.org on 2014/04/11 03:44:30 UTC
svn commit: r1586527 - in /hive/trunk/ql/src:
java/org/apache/hadoop/hive/ql/exec/vector/expressions/IsNull.java
test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java
Author: jitendra
Date: Fri Apr 11 01:44:29 2014
New Revision: 1586527
URL: http://svn.apache.org/r1586527
Log:
HIVE-6879: Vectorization: IsNull returns incorrect output column. (reviewed by Vikram)
Modified:
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IsNull.java
hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IsNull.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IsNull.java?rev=1586527&r1=1586526&r2=1586527&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IsNull.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IsNull.java Fri Apr 11 01:44:29 2014
@@ -84,7 +84,7 @@ public class IsNull extends VectorExpres
@Override
public int getOutputColumn() {
- return -1;
+ return outputColumn;
}
@Override
Modified: hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java?rev=1586527&r1=1586526&r2=1586527&view=diff
==============================================================================
--- hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java (original)
+++ hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java Fri Apr 11 01:44:29 2014
@@ -545,6 +545,7 @@ public class TestVectorizationContext {
ve = vc.getVectorExpression(isNullExpr, VectorExpressionDescriptor.Mode.PROJECTION);
assertEquals(ve.getClass(), IsNull.class);
assertEquals(2, ((IsNull) ve).getColNum());
+ assertEquals(3, ve.getOutputColumn());
assertEquals(ve.getChildExpressions()[0].getClass(), LongColGreaterLongScalar.class);
}