You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/18 10:55:08 UTC
[GitHub] [airflow] potiuk opened a new pull request #11628: Name and optionally preserve data volumes in Breeze
potiuk opened a new pull request #11628:
URL: https://github.com/apache/airflow/pull/11628
So far breeze used in-container data for persisting it (mysql redis,
postgres). This means that the data was kept as long, as long the
containers were running. If you stopped Breeze via `stop` command
the data was always deleted.
This changes the behaviour - each of the Breeze containers has
a named volume where data is kept. Those volumes are also deleted
by default when Breeze is stopped, but you can choose to preserve
them by adding ``--preserve-volumes`` when you run ``stop`` or
``restart`` command.
Fixes: #11625
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11628: Name and optionally preserve data volumes in Breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11628:
URL: https://github.com/apache/airflow/pull/11628#issuecomment-711171216
OK. This should do the trick. The test was run twice per machine (once in core and once in "mysql" type) and they were sharing the same volume. Turned out that teh "bulk_dump" file was not re-runnable, but simple random export file name solves the problem :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #11628: Name and optionally preserve data volumes in Breeze
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #11628:
URL: https://github.com/apache/airflow/pull/11628#issuecomment-711158154
I think I fixed it :). https://github.com/apache/airflow/pull/11628/commits/07714a2ef30524d55dff1668fe409eb40e2a4648#diff-d026c9a80c565accc7524fafac334e5735ebd05f1194349fb7c203caa7885d56R22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11628: Name and optionally preserve data volumes in Breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11628:
URL: https://github.com/apache/airflow/pull/11628#issuecomment-711185178
Random failure. Otherwise good. submitting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11628: Name and optionally preserve data volumes in Breeze
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11628:
URL: https://github.com/apache/airflow/pull/11628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11628: Name and optionally preserve data volumes in Breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11628:
URL: https://github.com/apache/airflow/pull/11628#issuecomment-711158154
I think I fixed it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11628: Name and optionally preserve data volumes in Breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11628:
URL: https://github.com/apache/airflow/pull/11628#issuecomment-711156809
Intereestingly - some of the tests failed for mysql :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org