You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ja...@apache.org on 2019/12/24 08:32:34 UTC
[hbase-operator-tools] branch master updated: HBASE-23609 Cleaned
up tests
This is an automated email from the ASF dual-hosted git repository.
janh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase-operator-tools.git
The following commit(s) were added to refs/heads/master by this push:
new 20bc5bd HBASE-23609 Cleaned up tests
20bc5bd is described below
commit 20bc5bdc64a985e34070c2cbe3b69848a964668b
Author: Jan Hentschel <ja...@apache.org>
AuthorDate: Tue Dec 24 09:32:28 2019 +0100
HBASE-23609 Cleaned up tests
Signed-off-by: stack <st...@apache.org>
---
.../java/org/apache/hbase/TestFsRegionsMetaRecoverer.java | 13 ++++---------
hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java | 3 +--
.../java/org/apache/hbase/TestHBCKCommandLineParsing.java | 1 -
.../java/org/apache/hbase/TestHBCKMetaTableAccessor.java | 1 -
.../java/org/apache/hbase/TestSchedulingRecoveries.java | 2 --
5 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/hbase-hbck2/src/test/java/org/apache/hbase/TestFsRegionsMetaRecoverer.java b/hbase-hbck2/src/test/java/org/apache/hbase/TestFsRegionsMetaRecoverer.java
index 8c9c35d..ee1c08c 100644
--- a/hbase-hbck2/src/test/java/org/apache/hbase/TestFsRegionsMetaRecoverer.java
+++ b/hbase-hbck2/src/test/java/org/apache/hbase/TestFsRegionsMetaRecoverer.java
@@ -20,7 +20,6 @@ package org.apache.hbase;
import static org.junit.Assert.assertEquals;
import java.io.ByteArrayInputStream;
-import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
@@ -56,7 +55,6 @@ import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos;
public class TestFsRegionsMetaRecoverer {
-
private Connection mockedConnection;
private FileSystem mockedFileSystem;
private Table mockedTable;
@@ -175,7 +173,6 @@ public class TestFsRegionsMetaRecoverer {
}
private static final class TestInputStreamSeekable extends FSInputStream {
-
private ByteArrayInputStream in;
private long length;
@@ -186,26 +183,24 @@ public class TestFsRegionsMetaRecoverer {
}
@Override
- public void seek(long l) throws IOException {
+ public void seek(long l) {
this.in.skip(l);
}
@Override
- public long getPos() throws IOException {
+ public long getPos() {
return this.length - in.available();
}
@Override
- public boolean seekToNewSource(long l) throws IOException {
+ public boolean seekToNewSource(long l) {
this.in.skip(l);
return true;
}
@Override
- public int read() throws IOException {
+ public int read() {
return in.read();
}
}
-
}
-
diff --git a/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java b/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java
index d16c9f1..7b9bf2a 100644
--- a/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java
+++ b/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java
@@ -260,7 +260,7 @@ public class TestHBCK2 {
final StringBuilder builder = new StringBuilder();
PrintStream originalOS = System.out;
OutputStream testOS = new OutputStream() {
- @Override public void write(int b) throws IOException {
+ @Override public void write(int b) {
builder.append((char)b);
}
};
@@ -349,5 +349,4 @@ public class TestHBCK2 {
fail(e.getMessage());
}
}
-
}
diff --git a/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKCommandLineParsing.java b/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKCommandLineParsing.java
index 31b0247..da37648 100644
--- a/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKCommandLineParsing.java
+++ b/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKCommandLineParsing.java
@@ -102,4 +102,3 @@ public class TestHBCKCommandLineParsing {
return os.toString();
}
}
-
diff --git a/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKMetaTableAccessor.java b/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKMetaTableAccessor.java
index 3ada5ef..7e23657 100644
--- a/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKMetaTableAccessor.java
+++ b/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCKMetaTableAccessor.java
@@ -43,7 +43,6 @@ import org.junit.rules.TestName;
* Test class for the MetaTableAccessor wrapper.
*/
public class TestHBCKMetaTableAccessor {
-
private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();
@Rule
diff --git a/hbase-hbck2/src/test/java/org/apache/hbase/TestSchedulingRecoveries.java b/hbase-hbck2/src/test/java/org/apache/hbase/TestSchedulingRecoveries.java
index 87388be..f238c7f 100644
--- a/hbase-hbck2/src/test/java/org/apache/hbase/TestSchedulingRecoveries.java
+++ b/hbase-hbck2/src/test/java/org/apache/hbase/TestSchedulingRecoveries.java
@@ -33,8 +33,6 @@ import org.junit.Test;
import org.apache.hbase.thirdparty.com.google.protobuf.ServiceException;
-
-
public class TestSchedulingRecoveries {
private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();
private HBCK2 hbck2;