[GitHub] [incubator-doris] Lchangliang commented on a diff in pull request #8923: [Feature] Support compression prop

[GitBox <gi...@apache.org>]

Lchangliang commented on code in PR #8923:
URL: https://github.com/apache/incubator-doris/pull/8923#discussion_r880313916


##########
be/src/olap/tablet_meta.cpp:
##########
@@ -90,8 +91,34 @@ TabletMeta::TabletMeta(int64_t table_id, int64_t partition_id, int64_t tablet_id
         LOG(WARNING) << "unknown tablet keys type";
         break;
     }
+
     schema->set_compress_kind(COMPRESS_LZ4);
 
+    switch (compression_type)
+    {
+    case TCompressionType::NO_COMPRESSION:
+        schema->set_compression_type(NO_COMPRESSION);

Review Comment:
   I add some annotation to explain their differences.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org