You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "niebayes (via GitHub)" <gi...@apache.org> on 2023/06/01 15:49:39 UTC
[GitHub] [doris] niebayes opened a new pull request, #20351: add bin/fe.pid to .gitignore
niebayes opened a new pull request, #20351:
URL: https://github.com/apache/doris/pull/20351
## Proposed changes
Issue Number: No.
<--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #20351: add bin/fe.pid to .gitignore
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #20351:
URL: https://github.com/apache/doris/pull/20351#issuecomment-1573069229
why need to add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] niebayes commented on pull request #20351: add bin/fe.pid to .gitignore
Posted by "niebayes (via GitHub)" <gi...@apache.org>.
niebayes commented on PR #20351:
URL: https://github.com/apache/doris/pull/20351#issuecomment-1573091797
@jackwener There resides a `bin` directory in the source root. By accident someone, like me, would execute scripts in that directory. As a consequence, a pid file will be generated. This file by no means shall be tracked by Git.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] niebayes closed pull request #20351: add bin/fe.pid to .gitignore
Posted by "niebayes (via GitHub)" <gi...@apache.org>.
niebayes closed pull request #20351: add bin/fe.pid to .gitignore
URL: https://github.com/apache/doris/pull/20351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #20351: add bin/fe.pid to .gitignore
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #20351:
URL: https://github.com/apache/doris/pull/20351#issuecomment-1573092813
doris `bin` dir is in `output/....`, why is it in `doris/bin/`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org