You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/02/17 01:27:10 UTC
[kudu-CR] python: pin pytest-runner to <5.3.0
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17074
Change subject: python: pin pytest-runner to <5.3.0
......................................................................
python: pin pytest-runner to <5.3.0
Per https://github.com/pytest-dev/pytest-runner/blob/v5.3.0/CHANGES.rst,
version 5.3.0 started requiring python 3.6 or higher, which is above the
minimum supported for Kudu. So, this pins us the version to below 5.3.0.
Change-Id: I54fe40b0a6e56f74c4a3d7ce2d336d25ce6a33e2
---
M python/setup.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/17074/1
--
To view, visit http://gerrit.cloudera.org:8080/17074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54fe40b0a6e56f74c4a3d7ce2d336d25ce6a33e2
Gerrit-Change-Number: 17074
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] python: pin pytest-runner to <5.3.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17074 )
Change subject: python: pin pytest-runner to <5.3.0
......................................................................
Patch Set 3: Code-Review+2
> Change has been successfully cherry-picked as f24ec6a7757af421f6da3e5f4b93f3a6761d23bb
> by Andrew Wong
Thank you for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/17074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fe40b0a6e56f74c4a3d7ce2d336d25ce6a33e2
Gerrit-Change-Number: 17074
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Feb 2021 03:30:54 +0000
Gerrit-HasComments: No
[kudu-CR] python: pin pytest-runner to <5.3.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17074 )
Change subject: python: pin pytest-runner to <5.3.0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fe40b0a6e56f74c4a3d7ce2d336d25ce6a33e2
Gerrit-Change-Number: 17074
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Feb 2021 02:21:05 +0000
Gerrit-HasComments: No
[kudu-CR] python: pin pytest-runner to <5.3.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17074
to look at the new patch set (#2).
Change subject: python: pin pytest-runner to <5.3.0
......................................................................
python: pin pytest-runner to <5.3.0
Per https://github.com/pytest-dev/pytest-runner/blob/v5.3.0/CHANGES.rst,
version 5.3.0 started requiring python 3.6 or higher, which is above the
minimum supported for Kudu. So, this pins the version to below 5.3.0.
Change-Id: I54fe40b0a6e56f74c4a3d7ce2d336d25ce6a33e2
---
M python/setup.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/17074/2
--
To view, visit http://gerrit.cloudera.org:8080/17074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I54fe40b0a6e56f74c4a3d7ce2d336d25ce6a33e2
Gerrit-Change-Number: 17074
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] python: pin pytest-runner to <5.3.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17074 )
Change subject: python: pin pytest-runner to <5.3.0
......................................................................
python: pin pytest-runner to <5.3.0
Per https://github.com/pytest-dev/pytest-runner/blob/v5.3.0/CHANGES.rst,
version 5.3.0 started requiring python 3.6 or higher, which is above the
minimum supported for Kudu. So, this pins the version to below 5.3.0.
Change-Id: I54fe40b0a6e56f74c4a3d7ce2d336d25ce6a33e2
Reviewed-on: http://gerrit.cloudera.org:8080/17074
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M python/setup.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I54fe40b0a6e56f74c4a3d7ce2d336d25ce6a33e2
Gerrit-Change-Number: 17074
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)