all tests should pass before committing?

[Kent Tong <ke...@cpttm.org.mo>]

Hi,

I often find some tests fail in SVN. This makes it very difficult for others
to contribute to the code as we just aren't sure if our changes break anything.
I think that's the purpose why all those tests were written in the first 
place. Therefore, I'd suggest that all committers ensure all the tests pass
before committing. What do you think?

--
Author of a book for learning Tapestry (http://www.agileskills2.org/EWDT)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: all tests should pass before committing?

[Kent Tong <ke...@cpttm.org.mo>]

Howard Lewis Ship <hlship <at> gmail.com> writes:

> I would love to know what tests fail and why. With the environment
> easier to set up than before (Maven and all that) tests should just
> run.

Those tests failed because of the new modifications (eg, JSON). The 
code was changed but the tests weren't updated.

--
Kent Tong
Author of a book for learning Tapestry (http://www.agileskills2.org/EWDT)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: all tests should pass before committing?

[Howard Lewis Ship <hl...@gmail.com>]

I would love to know what tests fail and why. With the environment
easier to set up than before (Maven and all that) tests should just
run.

Generally it ends up being because of either a localization issue
(different default locale), or line endings problem (windows vs. unix
style) or a difference in JVM (Sun vs. IBM, etc.).

All of these cases are solvable.  Localization by setting Locale's
default properly. LIne endings by managing files in SVN appropriately.
JVM differences (often in terms of exception messages) may be solvable
too.  The first step is to identify the problem in JIRA:  Especially,
operating system, JDK version, and locale.

On 7/16/06, Kent Tong <ke...@cpttm.org.mo> wrote:
> Jesse Kuhnert <jkuhnert <at> gmail.com> writes:
>
> > I think that generally sounds like a good idea. When was the last time you
> > noticed some failing tests?
>
> The last time was about a week ago.
>
> --
> Author of a book for learning Tapestry (http://www.agileskills2.org/EWDT)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>


-- 
Howard M. Lewis Ship
Independent J2EE / Open-Source Java Consultant
Creator and PMC Chair, Apache Tapestry
Creator, Jakarta HiveMind

Professional Tapestry training, mentoring, support
and project work.  http://howardlewisship.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: all tests should pass before committing?

[Kent Tong <ke...@cpttm.org.mo>]

Jesse Kuhnert <jkuhnert <at> gmail.com> writes:

> I think that generally sounds like a good idea. When was the last time you
> noticed some failing tests?

The last time was about a week ago.

--
Author of a book for learning Tapestry (http://www.agileskills2.org/EWDT)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: all tests should pass before committing?

[Jesse Kuhnert <jk...@gmail.com>]

I think that generally sounds like a good idea. When was the last time you
noticed some failing tests?

On 7/15/06, Kent Tong <ke...@cpttm.org.mo> wrote:
>
> Hi,
>
> I often find some tests fail in SVN. This makes it very difficult for
> others
> to contribute to the code as we just aren't sure if our changes break
> anything.
> I think that's the purpose why all those tests were written in the first
> place. Therefore, I'd suggest that all committers ensure all the tests
> pass
> before committing. What do you think?
>
> --
> Author of a book for learning Tapestry (http://www.agileskills2.org/EWDT)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>


-- 
Jesse Kuhnert
Tacos/Tapestry, team member/developer

Open source based consulting work centered around
dojo/tapestry/tacos/hivemind.