You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by in...@apache.org on 2019/11/15 21:30:29 UTC
[hadoop] branch branch-3.1 updated: HADOOP-16705. MBeanInfoBuilder
puts unnecessary memory pressure on the system with a debug log.
This is an automated email from the ASF dual-hosted git repository.
inigoiri pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new 50d98a6 HADOOP-16705. MBeanInfoBuilder puts unnecessary memory pressure on the system with a debug log.
50d98a6 is described below
commit 50d98a6568c6662d2757cf73cb9e066b4f808c75
Author: Lukas Majercak <lu...@gmail.com>
AuthorDate: Thu Nov 14 09:54:02 2019 -0800
HADOOP-16705. MBeanInfoBuilder puts unnecessary memory pressure on the system with a debug log.
MBeanInfoBuilder's get() method DEBUG logs all the MBeanAttributeInfo attributes that it gathered. This can have a high memory churn that can be easily avoided.
(cherry picked from commit c73334a924d2009d136a8ee62278aaac53418a24)
---
.../src/main/java/org/apache/hadoop/metrics2/impl/MBeanInfoBuilder.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MBeanInfoBuilder.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MBeanInfoBuilder.java
index 5282119..cdd0ba4 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MBeanInfoBuilder.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MBeanInfoBuilder.java
@@ -106,7 +106,7 @@ class MBeanInfoBuilder implements MetricsVisitor {
}
++curRecNo;
}
- MetricsSystemImpl.LOG.debug(attrs.toString());
+ MetricsSystemImpl.LOG.debug("{}", attrs);
MBeanAttributeInfo[] attrsArray = new MBeanAttributeInfo[attrs.size()];
return new MBeanInfo(name, description, attrs.toArray(attrsArray),
null, null, null); // no ops/ctors/notifications
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org