You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/20 01:38:41 UTC

[GitHub] [rocketmq] xiaoyifang commented on pull request #5713: [ISSUE #5710] optimize ServiceThread's waitForRunning logic

xiaoyifang commented on PR #5713:
URL: https://github.com/apache/rocketmq/pull/5713#issuecomment-1358717527

   In the future edition , 
   I think `hasNotified` can be removed and use `isStop` instead. these two variables share some common senarios.
   
   pesudocode:
   `
   if(!isStop){
   await(N,millionseconds)
   }
   `
   
    This can be in a new PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org