[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #195: Changes to support building in IntelliJ

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #195: Changes to support building in IntelliJ
URL: https://github.com/apache/incubator-daffodil/pull/195#discussion_r265124968
 
 

 ##########
 File path: daffodil-test-ibm1/src/test/scala/org/apache/daffodil/TresysTests.scala
 ##########
 @@ -158,9 +175,35 @@ class TresysTests {
 
   @Test def test_AZ000() { runnerAZ.runOneTest("AZ000") } // escape schemes
 
-  // Jira DFDL-1392
-  //  @Test def test_BA000() { runnerBA.runOneTest("BA000") } // escape schemes and delimiters
+  // Jira DFDL-1392 - Issue with escapeEscape character that is first and precedes an escape-block start.
+  // Is being removed, but should be preserved as it does not precede an escape character, nor an escape block end.
+  //@Test def test_BA000() { runnerBA.runOneTest("BA000") } // escape schemes and delimiters
+  //@Test def test_BB000() { runnerBB.runOneTest("BB000") } // occursCountKind stopValue
+
+  //DFDL-1010
+  //@Test def test_BE000() { runnerBE.runOneTest("BE000") } // unordered sequences
+  //@Test def test_BE001() { runnerBE.runOneTest("BE001") }
+
+  //DFDL-1010
+  //@Test def test_BF000() { runnerBF1.runOneTest("BF000") } // unordered sequences
+  //@Test def test_BF001() { runnerBF1.runOneTest("BF001") }
+
+  //@Test def test_BG000() { runnerBG.runOneTest("BG000") } // needs text numbers: advanced properties (DFDL-452)
+
+  //@Test def test_BC000() { runnerBC.runOneTest("BC000") } // text boolean type
 
 Review comment:
   I'm not sure how much that will really help that much since there's already alot of tests that are commented out but don't have associated bugs in the comment. Grepping for ``//.*@Test`` finds just over 300 instances of commented out bugs, but grepping for ``//.*(DFDL|DAFFODIL)-`` finds just under 200 tickets mentioned. Could be some are grouped together under a single issue, but I skimmed through commented out tests and quickly came across many that didn't have an associated bug.
   
   Maybe we should instead create a new issue to go through commented out tests and either enable those that pass or create bugs for those that don't pass but don't have an associated bug?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services