You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/24 08:13:24 UTC

[GitHub] [rocketmq-spring] liuliuzo opened a new issue #313: special security requirement

liuliuzo opened a new issue #313:
URL: https://github.com/apache/rocketmq-spring/issues/313


   for our security requirement application can‘t logging the message because message contain sensitive data.
   can we fix  log.error("syncSend failed. destination:{}, **message:{}** ", destination, **message**); when catch Exception ? better only print message id
   `
       public SendResult syncSend(String destination, Message<?> message, long timeout, int delayLevel) {
           if (Objects.isNull(message) || Objects.isNull(message.getPayload())) {
               log.error("syncSend failed. destination:{}, message is null ", destination);
               throw new IllegalArgumentException("`message` and `message.payload` cannot be null");
           }
           try {
               long now = System.currentTimeMillis();
               org.apache.rocketmq.common.message.Message rocketMsg = this.createRocketMqMessage(destination, message);
               if (delayLevel > 0) {
                   rocketMsg.setDelayTimeLevel(delayLevel);
               }
               SendResult sendResult = producer.send(rocketMsg, timeout);
               long costTime = System.currentTimeMillis() - now;
               if (log.isDebugEnabled()) {
                   log.debug("send message cost: {} ms, msgId:{}", costTime, sendResult.getMsgId());
               }
               return sendResult;
           } catch (Exception e) {
               log.error("syncSend failed. destination:{}, message:{} ", destination, message);
               throw new MessagingException(e.getMessage(), e);
           }
       }
   `
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq-spring] vongosling closed issue #313: Security requirement and less logs

Posted by GitBox <gi...@apache.org>.
vongosling closed issue #313:
URL: https://github.com/apache/rocketmq-spring/issues/313


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq-spring] liuliuzo closed issue #313: Security requirement

Posted by GitBox <gi...@apache.org>.
liuliuzo closed issue #313:
URL: https://github.com/apache/rocketmq-spring/issues/313


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq-spring] vongosling commented on issue #313: Security requirement and less logs

Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #313:
URL: https://github.com/apache/rocketmq-spring/issues/313#issuecomment-735509806


   You could try to override the log module(intercept logging) to finish your privacy needs if you do not want to encode the message.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org