You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/03 19:00:02 UTC

[GitHub] [tvm] mbaret commented on pull request #8924: [ONNX] Add OpSet 13 implementation for Hardmax and type annotations

mbaret commented on pull request #8924:
URL: https://github.com/apache/tvm/pull/8924#issuecomment-912746236


   Just to add another comment in favour of splitting the PRs, if we have patches that fix/cause issues we may very well want to revert them or cherry pick them onto older releases. In those cases, we don't want typing fixes to be associated with functional changes. I still think it's a good intiative to update the typing as you work in a particular area, but those typing changes can land in a separate PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org