You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/22 19:14:51 UTC
[GitHub] [airflow] potiuk opened a new issue #8977: Secrets and Protocols are note checked if they are tested
potiuk opened a new issue #8977:
URL: https://github.com/apache/airflow/issues/8977
**Description**
The test_project_structure does not check for files that are protocols or secrets. Only operators/hooks/sensors are checked.
**Use case / motivation**
If there are untested secrets or protocols they should also be flagged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #8977: Secrets and Protocols are note checked if they are tested
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8977:
URL: https://github.com/apache/airflow/issues/8977#issuecomment-632866996
cc @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #8977: Secrets and Protocols are note checked if they are tested
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8977:
URL: https://github.com/apache/airflow/issues/8977#issuecomment-632886031
It seems to me that all files are checked.
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L84
However, I can see that we can add new deprecated packages for testing
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L60
This is not a big problem, because it is very difficult to make such a mistake. I was worried about the operators because someone could do rebase.
We also have one typo - airlfow => airflow
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #8977: Secrets and Protocols are note checked if they are tested
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8977:
URL: https://github.com/apache/airflow/issues/8977#issuecomment-633023929
I wanted to check what you just fixed in #8979 and #8978 so I think we can close this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #8977: Secrets and Protocols are note checked if they are tested
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #8977:
URL: https://github.com/apache/airflow/issues/8977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #8977: Secrets and Protocols are note checked if they are tested
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #8977:
URL: https://github.com/apache/airflow/issues/8977#issuecomment-632886031
It seems to me that all files are checked.
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L84
However, I can see that we can add new deprecated packages for testing
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L60
This is not a big problem, because it is very difficult to make such a mistake. I was worried about the operators because someone could do rebase.
We also have one typo - airlfow => airflow
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L247
What exactly would you like to check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #8977: Secrets and Protocols are note checked if they are tested
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #8977:
URL: https://github.com/apache/airflow/issues/8977#issuecomment-632886031
It seems to me that all files are checked.
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L84
However, I can see that we can add new deprecated packages for testing
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L60
This is not a big problem, because it is very difficult to make such a mistake. When I added this test, I was worried about the operators because someone could do rebase and create new file.
We also have one typo - airlfow => airflow
https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L247
What exactly would you like to check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org