You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/06 17:56:00 UTC
[jira] [Commented] (KAFKA-4641) Improve test coverage of
StreamsThread
[ https://issues.apache.org/jira/browse/KAFKA-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354236#comment-16354236 ]
ASF GitHub Bot commented on KAFKA-4641:
---------------------------------------
guozhangwang opened a new pull request #4531: KAFKA-4641: Add more unit test for stream thread
URL: https://github.com/apache/kafka/pull/4531
Before the patch, jacoco coverage test:
Element | Missed Instructions | Cov. | Missed Branches | Cov. | Missed | Cxty | Missed | Lines | Missed | Methods | Missed | Classes
-- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
Total | 3,386 of 22,177 | 84% | 336 of 1,639 | 79% | 350 | 1,589 | 526 | 4,451 | 103 | 768 | 1 | 102
StreamThread | | 77% | | 76% | 27 | 102 | 48 | 299 | 1 | 31 | 0 | 1
After the patch:
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Improve test coverage of StreamsThread
> --------------------------------------
>
> Key: KAFKA-4641
> URL: https://issues.apache.org/jira/browse/KAFKA-4641
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
> Affects Versions: 0.11.0.0
> Reporter: Damian Guy
> Priority: Minor
> Labels: newbie
>
> Some methods in {{StreamThread}} have little or no coverage.
> In particular:
> {{maybeUpdateStandbyTasks}} has little to no coverage
> Committing of StandbyTasks in {{commitAll}}
> {{maybePunctuate}}
> {{commitOne}} - no tests for exceptions
> {{unAssignChangeLogPartitions} - no tests for exceptions
> {{addStreamsTask}} - no tests for exceptions
> {{runLoop}}
> Please see coverage report attached to parent
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)