[GitHub] [incubator-superset] villebro commented on a change in pull request #10336: fix: make __time an ok column name in SQL Lab

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10336:
URL: https://github.com/apache/incubator-superset/pull/10336#discussion_r455553406



##########
File path: superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx
##########
@@ -104,7 +104,7 @@ class ExploreResultsButton extends React.PureComponent {
   getInvalidColumns() {
     const re1 = /^[A-Za-z_]\w*$/; // starts with char or _, then only alphanum
     const re2 = /__\d+$/; // does not finish with __ and then a number which screams dup col name
-    const re3 = /^__/; // is not a reserved column name e.g. __timestamp
+    const re3 = /^__timestamp/i; // is not a reserved temporal column alias

Review comment:
       the trailing `/i` to make matching cases-insensitive.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org