You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/05/13 21:27:56 UTC
Review Request 34178: Upgrade to 2.0.1,
unable to RU (can't get installed)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34178/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav Papirkovskyy, and Nate Cole.
Bugs: AMBARI-11116
https://issues.apache.org/jira/browse/AMBARI-11116
Repository: ambari
Description
-------
Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
1) single node cluster, Ambari 2.0.0 GA, default postgres database
2) HDP 2.2.0.0
3) all installed and green, then upgrade to Ambari 2.0.1 (build #34)
4) all green, registered HDP 2.2.4.2, attempted to install
5) that completed but ambari Versions is stuck showing "Installing..."
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 659fb21
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 85973b1
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 5435982
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/GroupDAO.java bd5defb
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java f927197
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/MemberDAO.java e831db2
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PermissionDAO.java 939c32b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrincipalDAO.java 7ac4f05
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrincipalTypeDAO.java 046345a
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrivilegeDAO.java 4fda7bc
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java c2b551b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java a9b913f
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 2fcb087
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewDAO.java bbbab63
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java 91a2e72
Diff: https://reviews.apache.org/r/34178/diff/
Testing
-------
Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
Thanks,
Dmitro Lisnichenko
Re: Review Request 34178: Upgrade to 2.0.1,
unable to RU (can't get installed)
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34178/
-----------------------------------------------------------
(Updated May 14, 2015, 1:45 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav Papirkovskyy, and Nate Cole.
Changes
-------
another attempt
Bugs: AMBARI-11116
https://issues.apache.org/jira/browse/AMBARI-11116
Repository: ambari
Description
-------
Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
1) single node cluster, Ambari 2.0.0 GA, default postgres database
2) HDP 2.2.0.0
3) all installed and green, then upgrade to Ambari 2.0.1 (build #34)
4) all green, registered HDP 2.2.4.2, attempted to install
5) that completed but ambari Versions is stuck showing "Installing..."
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 659fb21
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 85973b1
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertHostSummaryDTO.java c73948d
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertSummaryDTO.java f56875f
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 5435982
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ArtifactDAO.java 27346dd
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java 9b58422
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 55e2aef
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterServiceDAO.java 1306c6c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterStateDAO.java b9505e8
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java b7e0d1c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ConfigGroupConfigMappingDAO.java 7502a86
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ConfigGroupHostMappingDAO.java 592679e
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/CrudDAO.java 4382f59
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/DaoUtils.java 7f157ec
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExecutionCommandDAO.java 9a40a0c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/GroupDAO.java bd5defb
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java 8e92877
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java e7b5c10
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java 9bc1235
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostDAO.java 35c795b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java f927197
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostStateDAO.java f939de3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java d816102
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 126d768
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java 64e18bb
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KeyValueDAO.java b2d92b3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/MemberDAO.java e831db2
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/MetainfoDAO.java b6f737e
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PermissionDAO.java 939c32b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrincipalDAO.java 7ac4f05
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrincipalTypeDAO.java 046345a
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrivilegeDAO.java 4fda7bc
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java 7099c5c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 7e190a3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestScheduleBatchRequestDAO.java a61b643
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestScheduleDAO.java 259c3b2
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java e4ed9c6
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceTypeDAO.java 4f375ce
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RoleSuccessCriteriaDAO.java 87649ea
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java 341d1fd
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java 1b9d33d
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceDesiredStateDAO.java 81e6d95
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java c2b551b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java a9b913f
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 2fcb087
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewDAO.java bbbab63
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java 91a2e72
Diff: https://reviews.apache.org/r/34178/diff/
Testing
-------
Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
Thanks,
Dmitro Lisnichenko
Re: Review Request 34178: Upgrade to 2.0.1,
unable to RU (can't get installed)
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On May 14, 2015, 12:42 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java, lines 87-88
> > <https://reviews.apache.org/r/34178/diff/2/?file=959166#file959166line87>
> >
> > Is this not doing the same thing as RequiresSession? RequiresSession is calling AmbariLocalSessionInterceptor which invokes begin() and end() on a AmbariJpaPersistService.
> >
> > When you @Inject a UnitOfWork, the UnitOfWork is bound to a AmbariJpaPersistService
> >
> > So, this is doing the same work, no?
I expected it to do work on the higher level then DAO, but patch does not work. Just finished verification on live cluster
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34178/#review83755
-----------------------------------------------------------
On May 14, 2015, 12:20 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34178/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 12:20 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav Papirkovskyy, and Nate Cole.
>
>
> Bugs: AMBARI-11116
> https://issues.apache.org/jira/browse/AMBARI-11116
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
>
> 1) single node cluster, Ambari 2.0.0 GA, default postgres database
> 2) HDP 2.2.0.0
> 3) all installed and green, then upgrade to Ambari 2.0.1 (build #34)
> 4) all green, registered HDP 2.2.4.2, attempted to install
> 5) that completed but ambari Versions is stuck showing "Installing..."
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertDefinitionDisabledListener.java 010526b
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java 655352f
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHostListener.java d478bf5
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertLifecycleListener.java 780de84
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java c54baa2
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java 92008e3
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java fd7035d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java e4b26b1
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java dcc06a7
>
> Diff: https://reviews.apache.org/r/34178/diff/
>
>
> Testing
> -------
>
> Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 34178: Upgrade to 2.0.1,
unable to RU (can't get installed)
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34178/#review83755
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java
<https://reviews.apache.org/r/34178/#comment134817>
Is this not doing the same thing as RequiresSession? RequiresSession is calling AmbariLocalSessionInterceptor which invokes begin() and end() on a AmbariJpaPersistService.
When you @Inject a UnitOfWork, the UnitOfWork is bound to a AmbariJpaPersistService
So, this is doing the same work, no?
- Jonathan Hurley
On May 14, 2015, 8:20 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34178/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 8:20 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav Papirkovskyy, and Nate Cole.
>
>
> Bugs: AMBARI-11116
> https://issues.apache.org/jira/browse/AMBARI-11116
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
>
> 1) single node cluster, Ambari 2.0.0 GA, default postgres database
> 2) HDP 2.2.0.0
> 3) all installed and green, then upgrade to Ambari 2.0.1 (build #34)
> 4) all green, registered HDP 2.2.4.2, attempted to install
> 5) that completed but ambari Versions is stuck showing "Installing..."
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertDefinitionDisabledListener.java 010526b
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java 655352f
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHostListener.java d478bf5
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertLifecycleListener.java 780de84
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java c54baa2
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java 92008e3
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java fd7035d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java e4b26b1
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java dcc06a7
>
> Diff: https://reviews.apache.org/r/34178/diff/
>
>
> Testing
> -------
>
> Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 34178: Upgrade to 2.0.1,
unable to RU (can't get installed)
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34178/
-----------------------------------------------------------
(Updated May 14, 2015, 12:20 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav Papirkovskyy, and Nate Cole.
Changes
-------
New patch, testing it
Bugs: AMBARI-11116
https://issues.apache.org/jira/browse/AMBARI-11116
Repository: ambari
Description
-------
Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
1) single node cluster, Ambari 2.0.0 GA, default postgres database
2) HDP 2.2.0.0
3) all installed and green, then upgrade to Ambari 2.0.1 (build #34)
4) all green, registered HDP 2.2.4.2, attempted to install
5) that completed but ambari Versions is stuck showing "Installing..."
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertDefinitionDisabledListener.java 010526b
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java 655352f
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHostListener.java d478bf5
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertLifecycleListener.java 780de84
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java c54baa2
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java 92008e3
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java fd7035d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java e4b26b1
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java dcc06a7
Diff: https://reviews.apache.org/r/34178/diff/
Testing
-------
Manual check shows that patch does NOT fix the issue, publishing just for discussion purposes
Thanks,
Dmitro Lisnichenko