You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/11 08:17:21 UTC

[GitHub] [apisix] tzssangglass commented on a change in pull request #6070: chore(grpc-web): update mime of response to mime of request

tzssangglass commented on a change in pull request #6070:
URL: https://github.com/apache/apisix/pull/6070#discussion_r781861816



##########
File path: apisix/plugins/grpc-web.lua
##########
@@ -60,6 +59,9 @@ function _M.check_schema(conf)
 end
 
 function _M.access(conf, ctx)
+    -- set context variable mime
+    ctx.grpc_web_mime = core.request.header(ctx, "Content-Type")

Review comment:
       better to add a comment explaining why you need to set the ctx.grpc_web_mime in advance




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org