You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/03/25 10:00:27 UTC
[PR] [hotfix] Simplify the variabl checkpointStatsSnapshotCacheExpireAfterWrite [flink]
beliefer opened a new pull request, #26349:
URL: https://github.com/apache/flink/pull/26349
## What is the purpose of the change
This PR aims to simplify the `checkpointStatsSnapshotCacheExpireAfterWrite`
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Simplify the variable checkpointStatsSnapshotCacheExpireAfterWrite [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26349:
URL: https://github.com/apache/flink/pull/26349#issuecomment-2751380099
ping @tillrohrmann @hlteoh37 cc @1996fanrui @davidradl @GOODBOY008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Simplify the variable checkpointStatsSnapshotCacheExpireAfterWrite [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26349:
URL: https://github.com/apache/flink/pull/26349#issuecomment-2753133063
@1996fanrui @davidradl Thanks for all the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Simplify the variable checkpointStatsSnapshotCacheExpireAfterWrite [flink]
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on PR #26349:
URL: https://github.com/apache/flink/pull/26349#issuecomment-2766349352
Thanks for the work @beliefer :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Simplify the variable checkpointStatsSnapshotCacheExpireAfterWrite [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #26349:
URL: https://github.com/apache/flink/pull/26349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Simplify the variable checkpointStatsSnapshotCacheExpireAfterWrite [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26349:
URL: https://github.com/apache/flink/pull/26349#issuecomment-2750778516
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b7dd4dcf13de85d79041d1f12869427a1ea4d8bc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7dd4dcf13de85d79041d1f12869427a1ea4d8bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7dd4dcf13de85d79041d1f12869427a1ea4d8bc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Simplify the variable checkpointStatsSnapshotCacheExpireAfterWrite [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #26349:
URL: https://github.com/apache/flink/pull/26349#issuecomment-2751443875
@beliefer please could you add a unit test to confirm the behaviour:
- with a value
- when it picks it up from the REFRESH_INTERVAL
- if REFRESH_INTERVAL is not in milliseconds.
- and that it picks up the default REFRESH_INTERVAL if that is not in the config.
I think this will nail down the expected behaviour in unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Simplify the variable checkpointStatsSnapshotCacheExpireAfterWrite [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26349:
URL: https://github.com/apache/flink/pull/26349#issuecomment-2751539988
> I think this will nail down the expected behaviour in unit tests.
Tests updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Simplify the variable checkpointStatsSnapshotCacheExpireAfterWrite [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26349:
URL: https://github.com/apache/flink/pull/26349#issuecomment-2767877279
@1996fanrui @davidradl @hlteoh37 Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org