You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Chris Custine <no...@github.com> on 2014/06/29 23:25:09 UTC
[jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching throwing
UnsupportedOperationException but call still succeeds (#424)
Fixes https://issues.apache.org/jira/browse/JCLOUDS-594
Backport to 1.7.x
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds fixes/JCLOUDS-594-1.7.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/424
-- Commit Summary --
* JCLOUDS-594: ComputeService.suspendNodesMatching throwing UnsupportedOperationException but call still succeeds
-- File Changes --
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceAdapter.java (6)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceAdapterExpectTest.java (80)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerWithoutImageTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/predicates/ServerPredicatesMockTest.java (6)
M apis/openstack-nova/src/test/resources/server_details.json (2)
M apis/openstack-nova/src/test/resources/server_details_without_image.json (2)
M apis/openstack-nova/src/test/resources/server_list_details.json (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/424.patch
https://github.com/jclouds/jclouds/pull/424.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Andrew Phillips <no...@github.com>.
> Just bumping to see if you want to merge this backport
Will try to have a look a little later...thanks for the ping!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-48423481
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1413](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1413/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-47476051
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Andrew Phillips <no...@github.com>.
There's a bunch of new [Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/942/violations/), only I think only [this one](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/942/org.apache.jclouds.api$openstack-nova/violations/file/src/test/java/org/jclouds/openstack/nova/v2_0/predicates/ServerPredicatesMockTest.java/) is related to this PR.
Could you have a quick look, @ccustine? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-47680658
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Chris Custine <no...@github.com>.
@demobox Looks like those checkstyle violations were already there (they were fixed in master but not 1.7). I am happy to fix them in this PR but I think that might be confusing in the Git history. Let me know if you want me to fix them here.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-47695023
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #1413 FAILURE
[Spurious failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1413/console)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-47680289
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Chris Custine <no...@github.com>.
Closed #424.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#event-139615425
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Chris Custine <no...@github.com>.
@demobox I'm on it, and I'm sorry about the Checkstyle stuff, I need to figure out a way to get that into my workflow.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-47682317
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #942](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/942/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-47479901
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Andrew Phillips <no...@github.com>.
> Just bumping to see if you want to merge this backport
Done - merged to [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=f52a264). Thanks, @ccustine!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-48426676
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Chris Custine <no...@github.com>.
Thanks @demobox , I'll close this PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-48447731
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1296](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1296/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-47479209
Re: [jclouds] JCLOUDS-594: ComputeService.suspendNodesMatching
throwing UnsupportedOperationException but call still succeeds (#424)
Posted by Chris Custine <no...@github.com>.
@demobox Just bumping to see if you want to merge this backport
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/424#issuecomment-48420472