Re: Opportunities for cohesion improvement and refatoring.

[João Paulo Lemes Machado <le...@gmail.com>]

Hi Erick, Sorry to bother you, but did you take a look at my suggestion?

2017-07-22 19:47 GMT-03:00 João Paulo Lemes Machado <le...@gmail.com>
:

> Hi Erick, thank you for the comment. I created a issue on jira:
> https://issues.apache.org/jira/browse/LUCENE-7902.
>
> Can you take a look and tell me what you think?
>
>
>
> 2017-07-22 12:27 GMT-03:00 Erick Erickson <er...@gmail.com>:
>
>> It would be best for you to make concrete proposals, basically an
>> outline (I'd recommend relatively small chunks) of what kinds of
>> changes you are thinking about.
>>
>> Also, feel free to create a JIRA and attach a patch with any
>> refactorings you think are beneficial. It doesn't even have to be a
>> functioning patch for a first cut, just something concrete that people
>> can comment on.
>>
>> Best,
>> Erick
>>
>> On Sat, Jul 22, 2017 at 7:16 AM, João Paulo Lemes Machado
>> <le...@gmail.com> wrote:
>> > Hello everyone.
>> >
>> > My name is João Paulo, I am a graduate student the Federal University of
>> > Uberlandia, Brazil.
>> >
>> > I was analyzing the modularization of some classes of Lucene, and  I
>> > identified some opportunities for cohesion improvement in the following
>> > classes:
>> >
>> > IndexSearcher
>> > ArrayUtil
>> > FieldType
>> > Operations
>> > CheckIndex
>> >
>> > Could you please take a look and tell me if it's viable?
>> >
>> > Maybe some of these classes could benefit from some kind of refactoring
>> that
>> > we can discuss.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>

Re: Opportunities for cohesion improvement and refatoring.

[Erick Erickson <er...@gmail.com>]

Sorry, I don't have the spare cycles at present....

Best,
Erick

On Tue, Aug 1, 2017 at 4:12 PM, João Paulo Lemes Machado
<le...@gmail.com> wrote:
> Hi Erick, Sorry to bother you, but did you take a look at my suggestion?
>
> 2017-07-22 19:47 GMT-03:00 João Paulo Lemes Machado
> <le...@gmail.com>:
>>
>> Hi Erick, thank you for the comment. I created a issue on jira:
>> https://issues.apache.org/jira/browse/LUCENE-7902.
>>
>> Can you take a look and tell me what you think?
>>
>>
>>
>> 2017-07-22 12:27 GMT-03:00 Erick Erickson <er...@gmail.com>:
>>>
>>> It would be best for you to make concrete proposals, basically an
>>> outline (I'd recommend relatively small chunks) of what kinds of
>>> changes you are thinking about.
>>>
>>> Also, feel free to create a JIRA and attach a patch with any
>>> refactorings you think are beneficial. It doesn't even have to be a
>>> functioning patch for a first cut, just something concrete that people
>>> can comment on.
>>>
>>> Best,
>>> Erick
>>>
>>> On Sat, Jul 22, 2017 at 7:16 AM, João Paulo Lemes Machado
>>> <le...@gmail.com> wrote:
>>> > Hello everyone.
>>> >
>>> > My name is João Paulo, I am a graduate student the Federal University
>>> > of
>>> > Uberlandia, Brazil.
>>> >
>>> > I was analyzing the modularization of some classes of Lucene, and  I
>>> > identified some opportunities for cohesion improvement in the following
>>> > classes:
>>> >
>>> > IndexSearcher
>>> > ArrayUtil
>>> > FieldType
>>> > Operations
>>> > CheckIndex
>>> >
>>> > Could you please take a look and tell me if it's viable?
>>> >
>>> > Maybe some of these classes could benefit from some kind of refactoring
>>> > that
>>> > we can discuss.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org