You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/11 17:29:40 UTC

[GitHub] [flink] hlteoh37 opened a new pull request, #20244: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…

hlteoh37 opened a new pull request, #20244:
URL: https://github.com/apache/flink/pull/20244

   … for AsyncSinkWriter
   
   ## What is the purpose of the change
   This pull request makes the RateLimitingStrategy used in AsyncSinkWriter configurable by the sink implementer. That way a sink implementer can decide to implement a custom RateLimitingStrategy.
   
   
   ## Brief change log
   - Introduced RateLimitingStrategy interface
   - Implemented a CongestionControlRateLimitingStrategy
   - Migrated tracking of inFlightMessages from AsyncSinkWriter into the RateLimitingStrategy
   - Introduced logic within AsyncSinkWriter to check with RateLimitingStrategy if the next request should be blocked.
   - Introduced a new AsyncSinkWriter constructor and deprecated the old AsyncSinkWriter constructors.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   - Added test that verifies AsyncSinkWriter respects the RateLimitingStrategy passed into the constructor
   - Added test that verifies AIMDRateLimitingStrategy follows a linear increase and multiplicative decrease
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? [FLIP-242: Introduce configurable RateLimitingStrategy for Async Sink](https://cwiki.apache.org/confluence/display/FLINK/FLIP-242%3A+Introduce+configurable+RateLimitingStrategy+for+Async+Sink)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hlteoh37 closed pull request #20244: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…

Posted by GitBox <gi...@apache.org>.
hlteoh37 closed pull request #20244: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…
URL: https://github.com/apache/flink/pull/20244


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20244: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20244:
URL: https://github.com/apache/flink/pull/20244#issuecomment-1180680321

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3df3733e444ae9e2d66d94960b7401003378a0c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a3df3733e444ae9e2d66d94960b7401003378a0c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3df3733e444ae9e2d66d94960b7401003378a0c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org