You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Ivan Junckes Filho <iv...@gmail.com> on 2018/08/03 19:51:46 UTC
Microprofile JWT impl Enum injection
Hello guys, I did a fix so the Microprofile JWT impl has support for
injecting Enums. Basically checks if the injection point is an enum and
then convert it.
Please review:
https://github.com/apache/tomee/pull/143
Thanks.
Re: Microprofile JWT impl Enum injection
Posted by Ivan Junckes Filho <iv...@gmail.com>.
Cool, thanks David!
On Thu, Aug 9, 2018 at 2:55 AM Gurkan Erdogdu <cg...@gmail.com> wrote:
> >
> > I updated this so we don't have special code to convert enum, but rather
> > we use xbean-reflect's conversion capabilities which handles enum and
> much
> > more.
> >
>
> Thank you David.
>
> On Thu, Aug 9, 2018 at 8:00 AM, David Blevins <da...@gmail.com>
> wrote:
>
> > I updated this so we don't have special code to convert enum, but rather
> > we use xbean-reflect's conversion capabilities which handles enum and
> much
> > more.
> >
> > Small change:
> >
> > - https://github.com/apache/tomee/commit/1217e64a8a3eef021e9cad1e6eb02a
> > 4e5d2d38c4
> >
> > Xbean-reflect's conversion capabilities are basically as simple as:
> >
> > - `PropertyEditors.getValue(type, claimValue)`
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> > > On Aug 3, 2018, at 1:16 PM, Ivan Junckes Filho <iv...@gmail.com>
> > wrote:
> > >
> > > Thank you JL.
> > >
> > > On Fri, Aug 3, 2018 at 5:13 PM Jean-Louis Monteiro <
> > jlmonteiro@tomitribe.com>
> > > wrote:
> > >
> > >> Hey Ivan,
> > >>
> > >> Thanks for the patch.
> > >> I have reviewed and merge the PR against master and the backport to
> > >> tomee-7.1.x
> > >>
> > >>
> > >>
> > >> --
> > >> Jean-Louis Monteiro
> > >> http://twitter.com/jlouismonteiro
> > >> http://www.tomitribe.com
> > >>
> > >> On Fri, Aug 3, 2018 at 9:51 PM, Ivan Junckes Filho <
> > ivanjunckes@gmail.com>
> > >> wrote:
> > >>
> > >>> Hello guys, I did a fix so the Microprofile JWT impl has support for
> > >>> injecting Enums. Basically checks if the injection point is an enum
> and
> > >>> then convert it.
> > >>>
> > >>> Please review:
> > >>> https://github.com/apache/tomee/pull/143
> > >>>
> > >>> Thanks.
> > >>>
> > >>
> >
> >
>
Re: Microprofile JWT impl Enum injection
Posted by Gurkan Erdogdu <cg...@gmail.com>.
>
> I updated this so we don't have special code to convert enum, but rather
> we use xbean-reflect's conversion capabilities which handles enum and much
> more.
>
Thank you David.
On Thu, Aug 9, 2018 at 8:00 AM, David Blevins <da...@gmail.com>
wrote:
> I updated this so we don't have special code to convert enum, but rather
> we use xbean-reflect's conversion capabilities which handles enum and much
> more.
>
> Small change:
>
> - https://github.com/apache/tomee/commit/1217e64a8a3eef021e9cad1e6eb02a
> 4e5d2d38c4
>
> Xbean-reflect's conversion capabilities are basically as simple as:
>
> - `PropertyEditors.getValue(type, claimValue)`
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Aug 3, 2018, at 1:16 PM, Ivan Junckes Filho <iv...@gmail.com>
> wrote:
> >
> > Thank you JL.
> >
> > On Fri, Aug 3, 2018 at 5:13 PM Jean-Louis Monteiro <
> jlmonteiro@tomitribe.com>
> > wrote:
> >
> >> Hey Ivan,
> >>
> >> Thanks for the patch.
> >> I have reviewed and merge the PR against master and the backport to
> >> tomee-7.1.x
> >>
> >>
> >>
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >>
> >> On Fri, Aug 3, 2018 at 9:51 PM, Ivan Junckes Filho <
> ivanjunckes@gmail.com>
> >> wrote:
> >>
> >>> Hello guys, I did a fix so the Microprofile JWT impl has support for
> >>> injecting Enums. Basically checks if the injection point is an enum and
> >>> then convert it.
> >>>
> >>> Please review:
> >>> https://github.com/apache/tomee/pull/143
> >>>
> >>> Thanks.
> >>>
> >>
>
>
Re: Microprofile JWT impl Enum injection
Posted by David Blevins <da...@gmail.com>.
I updated this so we don't have special code to convert enum, but rather we use xbean-reflect's conversion capabilities which handles enum and much more.
Small change:
- https://github.com/apache/tomee/commit/1217e64a8a3eef021e9cad1e6eb02a4e5d2d38c4
Xbean-reflect's conversion capabilities are basically as simple as:
- `PropertyEditors.getValue(type, claimValue)`
--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com
> On Aug 3, 2018, at 1:16 PM, Ivan Junckes Filho <iv...@gmail.com> wrote:
>
> Thank you JL.
>
> On Fri, Aug 3, 2018 at 5:13 PM Jean-Louis Monteiro <jl...@tomitribe.com>
> wrote:
>
>> Hey Ivan,
>>
>> Thanks for the patch.
>> I have reviewed and merge the PR against master and the backport to
>> tomee-7.1.x
>>
>>
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>> On Fri, Aug 3, 2018 at 9:51 PM, Ivan Junckes Filho <iv...@gmail.com>
>> wrote:
>>
>>> Hello guys, I did a fix so the Microprofile JWT impl has support for
>>> injecting Enums. Basically checks if the injection point is an enum and
>>> then convert it.
>>>
>>> Please review:
>>> https://github.com/apache/tomee/pull/143
>>>
>>> Thanks.
>>>
>>
Re: Microprofile JWT impl Enum injection
Posted by Ivan Junckes Filho <iv...@gmail.com>.
Thank you JL.
On Fri, Aug 3, 2018 at 5:13 PM Jean-Louis Monteiro <jl...@tomitribe.com>
wrote:
> Hey Ivan,
>
> Thanks for the patch.
> I have reviewed and merge the PR against master and the backport to
> tomee-7.1.x
>
>
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
> On Fri, Aug 3, 2018 at 9:51 PM, Ivan Junckes Filho <iv...@gmail.com>
> wrote:
>
> > Hello guys, I did a fix so the Microprofile JWT impl has support for
> > injecting Enums. Basically checks if the injection point is an enum and
> > then convert it.
> >
> > Please review:
> > https://github.com/apache/tomee/pull/143
> >
> > Thanks.
> >
>
Re: Microprofile JWT impl Enum injection
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Hey Ivan,
Thanks for the patch.
I have reviewed and merge the PR against master and the backport to
tomee-7.1.x
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Aug 3, 2018 at 9:51 PM, Ivan Junckes Filho <iv...@gmail.com>
wrote:
> Hello guys, I did a fix so the Microprofile JWT impl has support for
> injecting Enums. Basically checks if the injection point is an enum and
> then convert it.
>
> Please review:
> https://github.com/apache/tomee/pull/143
>
> Thanks.
>