[GitHub] [druid] paul-rogers commented on pull request #13916: Document our conventions for writing messages

["paul-rogers (via GitHub)" <gi...@apache.org>]

paul-rogers commented on PR #13916:
URL: https://github.com/apache/druid/pull/13916#issuecomment-1468387332

   @imply-cheddar, error messages are for end users. Even when they are for sys admins or devs, they go to end users first. As an end user of many products, I find `column[foo]` to be odd and un-English like. There may well be a good technical reason, but since our audience is end users, and they don't know that technical goal, we should use normally accepted English practice. That should include quotes, but if we choose to use brackets in place of quotes, at least use common spacing.
   
   That said, the code works fine without spaces and users can get used to Druid style. So, LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org