You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2015/10/03 03:06:50 UTC

[GitHub] spark pull request: [SQL] SPARK-6981: Factor out SparkPlanner and ...

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6356#discussion_r41081769
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -114,7 +114,7 @@ private[sql] object DataFrame {
     @Experimental
     class DataFrame private[sql](
         @transient val sqlContext: SQLContext,
    -    @DeveloperApi @transient val queryExecution: SQLContext#QueryExecution) extends Serializable {
    +    @DeveloperApi @transient val queryExecution: QueryExecution) extends Serializable {
    --- End diff --
    
    @marmbrus This changes the signature of `queryExecution`. Is there anyway that we can preserve the binary compatibility?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org