You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2015/08/11 21:31:45 UTC
[GitHub] trafficserver pull request: TS-3797: Crashes due to cross-thread r...
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/275
TS-3797: Crashes due to cross-thread race conditions.
We have been testing a version of this in production on a few machines for the past two weeks. We are expanding the testing to more machines.
This patch is slightly different than what we are running in production. I've done a bit a clean up (removing asserts and unifying changed methods that didn't really need to be there). The biggest difference from what we are running in production is moving the locking logic in HttpSessionManager::acquire_session to release the global pool lock sooner. I'm running this version on a single test box in production at this point. Will roll these changes back into broader production after the initial version passes muster (plus changes that get identified in this review).
Article describing the design of VC Migration https://cwiki.apache.org/confluence/display/TS/Threading+Issues+And+NetVC+Migration
Also a heads up that while I'm calling this VC migration, the only thing that is migrating is the socket and the SSL object. The actual VC data structures are re-created on the new thread.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-3797
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit fe7edce412a8d066a1207cefb421824b4a2ac0ce
Author: shinrich <sh...@yahoo-inc.com>
Date: 2015-08-11T19:20:46Z
TS-3797: Crashes due to cross-thread race conditions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3797: Crashes due to cross-thread r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---