You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/10/08 20:33:54 UTC

Review Request 26449: Cluster state is lost when session is expired during cluster installation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26449/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-7691
    https://issues.apache.org/jira/browse/AMBARI-7691


Repository: ambari


Description
-------

STR:

1. Install cluster up to step {{Install, Start, and Test}}
2. Ensure that cluster is installed in fact (Green progress bar)
3. Wait some time to session get expired

AR:
Installer is broken, even after re-login. See the screenshot. Login, relogin, even {{localStorage.clean()}} does not help.

ER:
Cluster installer should go to already done step (Step Summary) after login.

---
It looks like this is because we set Cluster state from UI but session is already expired and the request to update the cluster state does not reach the server, see BUG-21903 and comments there.
Namely status of cluster is still {{INIT}} in database
select provisioning_state from clusters

 provisioning_state
 ------------------
 INIT

But actually cluster in installed and all services are running.


Diffs
-----

  ambari-web/app/mappers/stack_mapper.js 8319f87 
  ambari-web/app/mixins/common/userPref.js 90a115d 
  ambari-web/test/controllers/installer_test.js b6b5d94 
  ambari-web/test/mappers/stack_mapper_test.js 2f8b10d 

Diff: https://reviews.apache.org/r/26449/diff/


Testing
-------

4505 tests complete (7 seconds)
  60 tests pending


Thanks,

Andrii Tkach


Re: Review Request 26449: Cluster state is lost when session is expired during cluster installation

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26449/#review56099
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 8, 2014, 6:33 p.m., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26449/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 6:33 p.m.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-7691
>     https://issues.apache.org/jira/browse/AMBARI-7691
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> 
> 1. Install cluster up to step {{Install, Start, and Test}}
> 2. Ensure that cluster is installed in fact (Green progress bar)
> 3. Wait some time to session get expired
> 
> AR:
> Installer is broken, even after re-login. See the screenshot. Login, relogin, even {{localStorage.clean()}} does not help.
> 
> ER:
> Cluster installer should go to already done step (Step Summary) after login.
> 
> ---
> It looks like this is because we set Cluster state from UI but session is already expired and the request to update the cluster state does not reach the server, see BUG-21903 and comments there.
> Namely status of cluster is still {{INIT}} in database
> select provisioning_state from clusters
> 
>  provisioning_state
>  ------------------
>  INIT
> 
> But actually cluster in installed and all services are running.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/mappers/stack_mapper.js 8319f87 
>   ambari-web/app/mixins/common/userPref.js 90a115d 
>   ambari-web/test/controllers/installer_test.js b6b5d94 
>   ambari-web/test/mappers/stack_mapper_test.js 2f8b10d 
> 
> Diff: https://reviews.apache.org/r/26449/diff/
> 
> 
> Testing
> -------
> 
> 4505 tests complete (7 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>


Re: Review Request 26449: Cluster state is lost when session is expired during cluster installation

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26449/#review55852
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 8, 2014, 6:33 після полудня, Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26449/
> -----------------------------------------------------------
> 
> (Updated Жов. 8, 2014, 6:33 після полудня)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-7691
>     https://issues.apache.org/jira/browse/AMBARI-7691
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> 
> 1. Install cluster up to step {{Install, Start, and Test}}
> 2. Ensure that cluster is installed in fact (Green progress bar)
> 3. Wait some time to session get expired
> 
> AR:
> Installer is broken, even after re-login. See the screenshot. Login, relogin, even {{localStorage.clean()}} does not help.
> 
> ER:
> Cluster installer should go to already done step (Step Summary) after login.
> 
> ---
> It looks like this is because we set Cluster state from UI but session is already expired and the request to update the cluster state does not reach the server, see BUG-21903 and comments there.
> Namely status of cluster is still {{INIT}} in database
> select provisioning_state from clusters
> 
>  provisioning_state
>  ------------------
>  INIT
> 
> But actually cluster in installed and all services are running.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/mappers/stack_mapper.js 8319f87 
>   ambari-web/app/mixins/common/userPref.js 90a115d 
>   ambari-web/test/controllers/installer_test.js b6b5d94 
>   ambari-web/test/mappers/stack_mapper_test.js 2f8b10d 
> 
> Diff: https://reviews.apache.org/r/26449/diff/
> 
> 
> Testing
> -------
> 
> 4505 tests complete (7 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>