You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dbatomic (via GitHub)" <gi...@apache.org> on 2024/03/05 11:08:59 UTC
[PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
dbatomic opened a new pull request, #45389:
URL: https://github.com/apache/spark/pull/45389
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This change introduces support for JOINs for StringType that doesn't follow binary collations (e.g. *LCASE collations).
For intro into collation track please refer to root JIRA.
With this change we add new check that verifies whether hash based aggregations are supported (i.e. `HashBroadcastJoin` and `ShuffleHashJoin`). The check is based on existing `isBinaryStable` logic. If result of hash support is false logic will fallback to merge based join which works properly with non-binary collations.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
JOINs are not working properly with StringType with non default collation at this point.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes - change fixes join behaviour.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Tests in `CollationSuite` plus extending `collations.sql` golden files.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "dbatomic (via GitHub)" <gi...@apache.org>.
dbatomic commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1513004663
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanHelper {
})
})
}
+
+ test("inner join respects collations") {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "GideonPotok (via GitHub)" <gi...@apache.org>.
GideonPotok commented on PR #45389:
URL: https://github.com/apache/spark/pull/45389#issuecomment-1978798573
Why does this issue not seem to exist when I search it? https://issues.apache.org/jira/issues/?jql=project%20%3D%20SPARK%20AND%20text%20~%20SPARK-46835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512856918
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -228,9 +235,10 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// other choice.
case j @ ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, nonEquiCond,
_, left, right, hint) =>
+ val hashJoinSupport = hashJoinSupported(leftKeys, rightKeys)
def createBroadcastHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getBroadcastBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
+ val buildSide = Option(hashJoinSupport).filter(identity).flatMap(
Review Comment:
I feel it's clearer to do
```
val buildSide = if (hashJoinSupport) {
getBroadcastBuildSide...
} else {
None
}
```
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -246,8 +254,8 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
}
def createShuffleHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getShuffleHashJoinBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
+ val buildSide = Option(hashJoinSupport).filter(identity).flatMap(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512858148
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanHelper {
})
})
}
+
+ test("inner join respects collations") {
Review Comment:
How is this test different from golden file test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #45389: [SPARK-46835][SQL][Collations] Join support for non-binary collations
URL: https://github.com/apache/spark/pull/45389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "dbatomic (via GitHub)" <gi...@apache.org>.
dbatomic commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512870997
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -228,9 +235,10 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// other choice.
case j @ ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, nonEquiCond,
_, left, right, hint) =>
+ val hashJoinSupport = hashJoinSupported(leftKeys, rightKeys)
def createBroadcastHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getBroadcastBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
+ val buildSide = Option(hashJoinSupport).filter(identity).flatMap(
Review Comment:
Sure, this was my initial version as well. I thought that `Option` trick is more in scala style. Reverting back to if/else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "dbatomic (via GitHub)" <gi...@apache.org>.
dbatomic commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1513005783
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -205,6 +206,12 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
}
}
+ private def hashJoinSupported
+ (leftKeys: Seq[Expression], rightKeys: Seq[Expression]): Boolean = {
+ leftKeys.forall(e => UnsafeRowUtils.isBinaryStable(e.dataType)) &&
Review Comment:
Went with `leftKeys.concat(rightKeys)` since IDE complained that `union` is deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "dbatomic (via GitHub)" <gi...@apache.org>.
dbatomic commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512869445
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanHelper {
})
})
}
+
+ test("inner join respects collations") {
Review Comment:
It's same. Having this test may come in handy while developing hash based joins, given that it's easier to debug functional tests then golden files.
But if you feel that it is redundant I can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "GideonPotok (via GitHub)" <gi...@apache.org>.
GideonPotok commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512907243
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -228,37 +235,46 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// other choice.
case j @ ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, nonEquiCond,
_, left, right, hint) =>
+ val hashJoinSupport = hashJoinSupported(leftKeys, rightKeys)
def createBroadcastHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getBroadcastBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
- checkHintBuildSide(onlyLookingAtHint, buildSide, joinType, hint, true)
- buildSide.map {
- buildSide =>
- Seq(joins.BroadcastHashJoinExec(
- leftKeys,
- rightKeys,
- joinType,
- buildSide,
- nonEquiCond,
- planLater(left),
- planLater(right)))
+ if (hashJoinSupport) {
+ val buildSide = getBroadcastBuildSide(
+ left, right, joinType, hint, onlyLookingAtHint, conf)
+ checkHintBuildSide(onlyLookingAtHint, buildSide, joinType, hint, true)
+ buildSide.map {
+ buildSide =>
+ Seq(joins.BroadcastHashJoinExec(
+ leftKeys,
+ rightKeys,
+ joinType,
+ buildSide,
+ nonEquiCond,
+ planLater(left),
+ planLater(right)))
+ }
+ } else {
+ None
}
}
def createShuffleHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getShuffleHashJoinBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
- checkHintBuildSide(onlyLookingAtHint, buildSide, joinType, hint, false)
- buildSide.map {
- buildSide =>
- Seq(joins.ShuffledHashJoinExec(
- leftKeys,
- rightKeys,
- joinType,
- buildSide,
- nonEquiCond,
- planLater(left),
- planLater(right)))
+ if (hashJoinSupport) {
+ val buildSide = getShuffleHashJoinBuildSide(
+ left, right, joinType, hint, onlyLookingAtHint, conf)
+ checkHintBuildSide(onlyLookingAtHint, buildSide, joinType, hint, false)
+ buildSide.map {
+ buildSide =>
+ Seq(joins.ShuffledHashJoinExec(
+ leftKeys,
+ rightKeys,
+ joinType,
+ buildSide,
+ nonEquiCond,
+ planLater(left),
+ planLater(right)))
+ }
+ } else {
Review Comment:
As a spark user, I would want a WARN Log to show that due to use of non-default collation configuration, merge-based alternatives are being forced replacing hash-based joins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "GideonPotok (via GitHub)" <gi...@apache.org>.
GideonPotok commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512899167
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -205,6 +206,12 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
}
}
+ private def hashJoinSupported
+ (leftKeys: Seq[Expression], rightKeys: Seq[Expression]): Boolean = {
+ leftKeys.forall(e => UnsafeRowUtils.isBinaryStable(e.dataType)) &&
Review Comment:
```suggestion
leftKeys.union(rightKeys).forall(e => UnsafeRowUtils.isBinaryStable(e.dataType))
}
```
Just a suggestion -- Whichever you prefer. Doesn't actually matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "dbatomic (via GitHub)" <gi...@apache.org>.
dbatomic commented on PR #45389:
URL: https://github.com/apache/spark/pull/45389#issuecomment-1978807250
> Why does this issue not seem to exist when I search it? https://issues.apache.org/jira/issues/?jql=project%20%3D%20SPARK%20AND%20text%20~%20SPARK-46835
@GideonPotok - Not sure, here is a direct link:
https://issues.apache.org/jira/browse/SPARK-46835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "dbatomic (via GitHub)" <gi...@apache.org>.
dbatomic commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1513002552
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -228,37 +235,46 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
// other choice.
case j @ ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, nonEquiCond,
_, left, right, hint) =>
+ val hashJoinSupport = hashJoinSupported(leftKeys, rightKeys)
def createBroadcastHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getBroadcastBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
- checkHintBuildSide(onlyLookingAtHint, buildSide, joinType, hint, true)
- buildSide.map {
- buildSide =>
- Seq(joins.BroadcastHashJoinExec(
- leftKeys,
- rightKeys,
- joinType,
- buildSide,
- nonEquiCond,
- planLater(left),
- planLater(right)))
+ if (hashJoinSupport) {
+ val buildSide = getBroadcastBuildSide(
+ left, right, joinType, hint, onlyLookingAtHint, conf)
+ checkHintBuildSide(onlyLookingAtHint, buildSide, joinType, hint, true)
+ buildSide.map {
+ buildSide =>
+ Seq(joins.BroadcastHashJoinExec(
+ leftKeys,
+ rightKeys,
+ joinType,
+ buildSide,
+ nonEquiCond,
+ planLater(left),
+ planLater(right)))
+ }
+ } else {
+ None
}
}
def createShuffleHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getShuffleHashJoinBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
- checkHintBuildSide(onlyLookingAtHint, buildSide, joinType, hint, false)
- buildSide.map {
- buildSide =>
- Seq(joins.ShuffledHashJoinExec(
- leftKeys,
- rightKeys,
- joinType,
- buildSide,
- nonEquiCond,
- planLater(left),
- planLater(right)))
+ if (hashJoinSupport) {
+ val buildSide = getShuffleHashJoinBuildSide(
+ left, right, joinType, hint, onlyLookingAtHint, conf)
+ checkHintBuildSide(onlyLookingAtHint, buildSide, joinType, hint, false)
+ buildSide.map {
+ buildSide =>
+ Seq(joins.ShuffledHashJoinExec(
+ leftKeys,
+ rightKeys,
+ joinType,
+ buildSide,
+ nonEquiCond,
+ planLater(left),
+ planLater(right)))
+ }
+ } else {
Review Comment:
Yeah, this does make sense. Please check the latest iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #45389:
URL: https://github.com/apache/spark/pull/45389#issuecomment-1980164987
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512887045
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanHelper {
})
})
}
+
+ test("inner join respects collations") {
Review Comment:
Let's remove and add it back when we work on the hash join support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org