You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/09 21:58:28 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
dongjoon-hyun opened a new pull request, #39470:
URL: https://github.com/apache/spark/pull/39470
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39470:
URL: https://github.com/apache/spark/pull/39470#discussion_r1065148674
##########
docs/sql-performance-tuning.md:
##########
@@ -298,6 +319,14 @@ AQE converts sort-merge join to broadcast hash join when the runtime statistics
</td>
<td>3.2.0</td>
</tr>
+ <tr>
+ <td><code>spark.sql.adaptive.localShuffleReader.enabled</code></td>
Review Comment:
This is a non-internal configuration which has been defined and used for a while.
https://github.com/apache/spark/blob/786594734bd79017ebd42eb117b62958afad07bb/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L702-L709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39470:
URL: https://github.com/apache/spark/pull/39470#discussion_r1065148054
##########
docs/sql-performance-tuning.md:
##########
@@ -286,6 +286,27 @@ This feature coalesces the post shuffle partitions based on the map output stati
</tr>
</table>
+### Spliting skewed shuffle partitions
+ <table class="table">
+ <tr><th>Property Name</th><th>Default</th><th>Meaning</th><th>Since Version</th></tr>
+ <tr>
+ <td><code>spark.sql.adaptive.optimizeSkewsInRebalancePartitions.enabled</code></td>
+ <td>true</td>
+ <td>
+ When true and <code>spark.sql.adaptive.enabled</code> is true, Spark will optimize the skewed shuffle partitions in RebalancePartitions and split them to smaller ones according to the target size (specified by <code>spark.sql.adaptive.advisoryPartitionSizeInBytes</code>), to avoid data skew.
+ </td>
+ <td>3.2.0</td>
+ </tr>
+ <tr>
+ <td><code>spark.sql.adaptive.rebalancePartitionsSmallPartitionFactor</code></td>
Review Comment:
This is a non-internal configuration which has been defined and used for a while.
https://github.com/apache/spark/blob/786594734bd79017ebd42eb117b62958afad07bb/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L792-L799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39470:
URL: https://github.com/apache/spark/pull/39470#discussion_r1065146578
##########
docs/sql-migration-guide.md:
##########
@@ -35,6 +35,7 @@ license: |
- Valid values for `fmt` are case-insensitive `hex`, `base64`, `utf-8`, `utf8`.
- Since Spark 3.4, Spark throws only `PartitionsAlreadyExistException` when it creates partitions but some of them exist already. In Spark 3.3 or earlier, Spark can throw either `PartitionsAlreadyExistException` or `PartitionAlreadyExistsException`.
- Since Spark 3.4, Spark will do validation for partition spec in ALTER PARTITION to follow the behavior of `spark.sql.storeAssignmentPolicy` which may cause an exception if type conversion fails, e.g. `ALTER TABLE .. ADD PARTITION(p='a')` if column `p` is int type. To restore the legacy behavior, set `spark.sql.legacy.skipTypeValidationOnAlterPartition` to `true`.
+ - Since Spark 3.4, vectorized readers are enabled by default for the nested data types (array, map and struct). To restore the legacy behavior, set `spark.sql.orc.enableNestedColumnVectorizedReader` and `spark.sql.parquet.enableNestedColumnVectorizedReader` to `false`.
Review Comment:
This is #36124 and #39434 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #39470:
URL: https://github.com/apache/spark/pull/39470#issuecomment-1376643734
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39470:
URL: https://github.com/apache/spark/pull/39470#issuecomment-1376393722
cc @sunchao , @viirya , @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39470:
URL: https://github.com/apache/spark/pull/39470#discussion_r1065193660
##########
docs/sql-performance-tuning.md:
##########
@@ -342,4 +371,33 @@ Data skew can severely downgrade the performance of join queries. This feature d
</td>
<td>3.0.0</td>
</tr>
+ <tr>
+ <td><code>spark.sql.adaptive.forceOptimizeSkewedJoin</code></td>
+ <td>false</td>
+ <td>
+ When true, force enable OptimizeSkewedJoin even if it introduces extra shuffle.
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39470:
URL: https://github.com/apache/spark/pull/39470#discussion_r1065147517
##########
docs/sql-performance-tuning.md:
##########
@@ -286,6 +286,27 @@ This feature coalesces the post shuffle partitions based on the map output stati
</tr>
</table>
+### Spliting skewed shuffle partitions
+ <table class="table">
+ <tr><th>Property Name</th><th>Default</th><th>Meaning</th><th>Since Version</th></tr>
+ <tr>
+ <td><code>spark.sql.adaptive.optimizeSkewsInRebalancePartitions.enabled</code></td>
Review Comment:
This is a non-internal configuration which has been defined and used for a while.
- https://github.com/apache/spark/blob/786594734bd79017ebd42eb117b62958afad07bb/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L782-L790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39470:
URL: https://github.com/apache/spark/pull/39470#issuecomment-1376475749
Thank you, @sunchao and @viirya . Merged to master for Apache Spark 3.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
URL: https://github.com/apache/spark/pull/39470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #39470:
URL: https://github.com/apache/spark/pull/39470#issuecomment-1376595773
thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39470:
URL: https://github.com/apache/spark/pull/39470#issuecomment-1376646893
Thank you, @ulysses-you and @cloud-fan !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39470:
URL: https://github.com/apache/spark/pull/39470#discussion_r1065145969
##########
docs/sql-data-sources-orc.md:
##########
@@ -173,7 +172,7 @@ When reading from Hive metastore ORC tables and inserting to Hive metastore ORC
</tr>
<tr>
<td><code>spark.sql.orc.enableNestedColumnVectorizedReader</code></td>
- <td><code>false</code></td>
+ <td><code>true</code></td>
Review Comment:
This is #39434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #39470:
URL: https://github.com/apache/spark/pull/39470#discussion_r1065183384
##########
docs/sql-performance-tuning.md:
##########
@@ -342,4 +371,33 @@ Data skew can severely downgrade the performance of join queries. This feature d
</td>
<td>3.0.0</td>
</tr>
+ <tr>
+ <td><code>spark.sql.adaptive.forceOptimizeSkewedJoin</code></td>
+ <td>false</td>
+ <td>
+ When true, force enable OptimizeSkewedJoin even if it introduces extra shuffle.
Review Comment:
For `OptimizeSkewedJoin`, it might be hard to understand what it means here. May we provide a little context? For example,
```suggestion
When true, force enable OptimizeSkewedJoin, which is an adaptive rule to optimize skewed joins to avoid straggler tasks, even if it introduces extra shuffle.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39470: [SPARK-41951][DOCS] Update SQL migration guide and documentations
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39470:
URL: https://github.com/apache/spark/pull/39470#discussion_r1065148999
##########
docs/sql-performance-tuning.md:
##########
@@ -342,4 +371,33 @@ Data skew can severely downgrade the performance of join queries. This feature d
</td>
<td>3.0.0</td>
</tr>
+ <tr>
+ <td><code>spark.sql.adaptive.forceOptimizeSkewedJoin</code></td>
Review Comment:
This is a non-internal configuration which has been defined and used for a while.
https://github.com/apache/spark/blob/786594734bd79017ebd42eb117b62958afad07bb/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L801-L806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org