[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #310: Share buffer pool across all partitions

[GitBox <gi...@apache.org>]

wolfstudy commented on a change in pull request #310:
URL: https://github.com/apache/pulsar-client-go/pull/310#discussion_r450990843



##########
File path: perf/perf-producer.go
##########
@@ -62,6 +63,8 @@ func newProducerCommand() *cobra.Command {
 		"Publish rate. Set to 0 to go unthrottled")
 	flags.IntVarP(&produceArgs.BatchingTimeMillis, "batching-time", "b", 1,
 		"Batching grouping time in millis")
+	flags.IntVarP(&produceArgs.BatchingMaxSize, "batching-max-size", "", 128,
+		"Max size of a batch (in KB)")

Review comment:
       In `pulsar-perf produce` about `--batch-max-messages` is abbreviated and the default value is as follows, can I consider keeping the two consistent?
   
   
   ``` 
      -bm, --batch-max-messages
          Maximum number of messages per batch
          Default: 1000
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org