You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Vinod Kone (Created) (JIRA)" <ji...@apache.org> on 2011/11/16 03:04:52 UTC
[jira] [Created] (MESOS-86) Expose master url to the scheduler
Expose master url to the scheduler
----------------------------------
Key: MESOS-86
URL: https://issues.apache.org/jira/browse/MESOS-86
Project: Mesos
Issue Type: New Feature
Reporter: Vinod Kone
Introduce new / augment old api calls (callbacks) to expose the master url.
Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
1) Augment registered() callback to included this info
2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239097#comment-13239097 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------
(Updated 2012-03-27 01:24:56.797946)
Review request for mesos, Benjamin Hindman and John Sirois.
Changes
-------
added new callbacks to scheduler and executor.
Summary (updated)
-------
New Scheduler callbacks for master info (ip and port)
--> registered() callback now includes maste info
--> new re-registered() callback is called when a new master is elected
--> new masterLost() callback is called when mesos core doesnt detect an
active master (e.g: during election)
--> new executorLost() callback
New Executor callbacks
--> reregistered() callback
--> slaveLost() callback
This addresses bug MESOS-86.
https://issues.apache.org/jira/browse/MESOS-86
Diffs (updated)
-----
include/mesos/executor.hpp ef7bdf9
include/mesos/scheduler.hpp 5bcf065
src/common/values.cpp 09d162f
src/examples/java/TestExceptionFramework.java d15b132
src/examples/java/TestFramework.java f86646b
src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
src/examples/long_lived_executor.cpp 4b4abad
src/examples/long_lived_framework.cpp 2775f5a
src/examples/no_executor_framework.cpp fb31b25
src/examples/python/test_framework.py 0d71831
src/examples/test_executor.cpp ba54004
src/examples/test_framework.cpp 622f6ac
src/java/jni/convert.cpp 5c2bf21
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b
src/java/src/org/apache/mesos/Scheduler.java b01468b
src/launcher/executor.cpp da4203c
src/master/master.cpp 6110c17
src/messages/messages.proto 7f9cffe
src/python/native/proxy_executor.hpp 32df90b
src/python/native/proxy_executor.cpp d453406
src/python/native/proxy_scheduler.hpp d0e5dfd
src/python/native/proxy_scheduler.cpp 9717f44
src/python/src/mesos.py 25d762b
src/sched/sched.cpp 9440381
src/tests/exception_tests.cpp c14bacc
src/tests/fault_tolerance_tests.cpp 9e7d181
src/tests/master_tests.cpp 57db468
src/tests/resource_offers_tests.cpp a405888
src/tests/utils.hpp 9241567
Diff: https://reviews.apache.org/r/3083/diff
Testing (updated)
-------
make check
Thanks,
Vinod
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239198#comment-13239198 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------
(Updated 2012-03-27 05:39:13.559518)
Review request for mesos, Benjamin Hindman and John Sirois.
Changes
-------
swapped the arguments of frameworkmessage and sendframeworkmessage to be consistent.
added an optional SlaveID field to SlaveInfo
Summary
-------
New Scheduler callbacks for master info (ip and port)
--> registered() callback now includes maste info
--> new re-registered() callback is called when a new master is elected
--> new masterLost() callback is called when mesos core doesnt detect an
active master (e.g: during election)
--> new executorLost() callback
New Executor callbacks
--> reregistered() callback
--> slaveLost() callback
This addresses bug MESOS-86.
https://issues.apache.org/jira/browse/MESOS-86
Diffs (updated)
-----
include/mesos/executor.hpp ef7bdf9
include/mesos/mesos.proto 23aad17
include/mesos/scheduler.hpp 5bcf065
src/common/values.cpp 09d162f
src/examples/java/TestExceptionFramework.java d15b132
src/examples/java/TestFramework.java f86646b
src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
src/examples/long_lived_executor.cpp 4b4abad
src/examples/long_lived_framework.cpp 2775f5a
src/examples/no_executor_framework.cpp fb31b25
src/examples/python/test_framework.py 0d71831
src/examples/test_executor.cpp ba54004
src/examples/test_framework.cpp 622f6ac
src/exec/exec.cpp 060707ad
src/java/jni/convert.cpp 5c2bf21
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 129a108
src/java/src/org/apache/mesos/Scheduler.java b01468b
src/java/src/org/apache/mesos/SchedulerDriver.java 0638ee3
src/launcher/executor.cpp da4203c
src/master/master.cpp 6110c17
src/messages/messages.proto 7f9cffe
src/python/native/mesos_scheduler_driver_impl.cpp 9e088ef
src/python/native/proxy_executor.hpp 32df90b
src/python/native/proxy_executor.cpp d453406
src/python/native/proxy_scheduler.hpp d0e5dfd
src/python/native/proxy_scheduler.cpp 9717f44
src/python/src/mesos.py 25d762b
src/sched/sched.cpp 9440381
src/tests/exception_tests.cpp c14bacc
src/tests/fault_tolerance_tests.cpp 9e7d181
src/tests/master_tests.cpp 57db468
src/tests/resource_offers_tests.cpp a405888
src/tests/utils.hpp 9241567
Diff: https://reviews.apache.org/r/3083/diff
Testing
-------
make check
Thanks,
Vinod
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MESOS-86) Expose master url to the scheduler
Posted by "Sumedh Sawant (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sumedh Sawant reassigned MESOS-86:
----------------------------------
Assignee: Sumedh Sawant
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Sumedh Sawant
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MESOS-86) Expose master url to the scheduler
Posted by "Vinod Kone (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kone resolved MESOS-86.
-----------------------------
Resolution: Fixed
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238884#comment-13238884 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------
(Updated 2012-03-26 21:49:32.063624)
Review request for mesos, Benjamin Hindman and John Sirois.
Changes
-------
merged with the latest trunk
Summary
-------
New Scheduler callbacks for master info (ip and port)
--> registered() callback now includes maste info
--> new re-registered() callback is called when a new master is elected
--> new masterLost() callback is called when mesos core doesnt detect an
active master (e.g: during election)
This addresses bug MESOS-86.
https://issues.apache.org/jira/browse/MESOS-86
Diffs (updated)
-----
include/mesos/scheduler.hpp 5bcf065
src/examples/java/TestExceptionFramework.java d15b132
src/examples/java/TestFramework.java f86646b
src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
src/examples/long_lived_framework.cpp 2775f5a
src/examples/no_executor_framework.cpp fb31b25
src/examples/python/test_framework.py 0d71831
src/examples/test_framework.cpp 622f6ac
src/java/jni/convert.cpp 5c2bf21
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b
src/java/src/org/apache/mesos/Scheduler.java b01468b
src/master/master.cpp 6110c17
src/messages/messages.proto 7f9cffe
src/python/native/proxy_scheduler.hpp d0e5dfd
src/python/native/proxy_scheduler.cpp 9717f44
src/python/src/mesos.py 25d762b
src/sched/sched.cpp 9440381
src/tests/exception_tests.cpp c14bacc
src/tests/fault_tolerance_tests.cpp 9e7d181
src/tests/master_tests.cpp 57db468
src/tests/resource_offers_tests.cpp a405888
src/tests/utils.hpp 9241567
Diff: https://reviews.apache.org/r/3083/diff
Testing
-------
./bin/tests/all-tests
Thanks,
Vinod
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239098#comment-13239098 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------
(Updated 2012-03-27 01:25:17.748670)
Review request for mesos, Benjamin Hindman and John Sirois.
Changes
-------
changed title
Summary (updated)
-------
New Scheduler callbacks for master info (ip and port)
--> registered() callback now includes maste info
--> new re-registered() callback is called when a new master is elected
--> new masterLost() callback is called when mesos core doesnt detect an
active master (e.g: during election)
--> new executorLost() callback
New Executor callbacks
--> reregistered() callback
--> slaveLost() callback
This addresses bug MESOS-86.
https://issues.apache.org/jira/browse/MESOS-86
Diffs
-----
include/mesos/executor.hpp ef7bdf9
include/mesos/scheduler.hpp 5bcf065
src/common/values.cpp 09d162f
src/examples/java/TestExceptionFramework.java d15b132
src/examples/java/TestFramework.java f86646b
src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
src/examples/long_lived_executor.cpp 4b4abad
src/examples/long_lived_framework.cpp 2775f5a
src/examples/no_executor_framework.cpp fb31b25
src/examples/python/test_framework.py 0d71831
src/examples/test_executor.cpp ba54004
src/examples/test_framework.cpp 622f6ac
src/java/jni/convert.cpp 5c2bf21
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b
src/java/src/org/apache/mesos/Scheduler.java b01468b
src/launcher/executor.cpp da4203c
src/master/master.cpp 6110c17
src/messages/messages.proto 7f9cffe
src/python/native/proxy_executor.hpp 32df90b
src/python/native/proxy_executor.cpp d453406
src/python/native/proxy_scheduler.hpp d0e5dfd
src/python/native/proxy_scheduler.cpp 9717f44
src/python/src/mesos.py 25d762b
src/sched/sched.cpp 9440381
src/tests/exception_tests.cpp c14bacc
src/tests/fault_tolerance_tests.cpp 9e7d181
src/tests/master_tests.cpp 57db468
src/tests/resource_offers_tests.cpp a405888
src/tests/utils.hpp 9241567
Diff: https://reviews.apache.org/r/3083/diff
Testing
-------
make check
Thanks,
Vinod
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165791#comment-13165791 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and John Sirois.
Summary
-------
New Scheduler callbacks for master info (ip and port)
--> registered() callback now includes maste info
--> new re-registered() callback is called when a new master is elected
--> new masterLost() callback is called when mesos core doesnt detect an
active master (e.g: during election)
This addresses bug MESOS-86.
https://issues.apache.org/jira/browse/MESOS-86
Diffs
-----
include/mesos/scheduler.hpp 93dda98
src/examples/cpp_test_framework.cpp ab02805
src/examples/java/TestExceptionFramework.java ba39757
src/examples/java/TestFramework.java e1b6032
src/examples/java/TestMultipleExecutorsFramework.java a49ecbb
src/examples/long_lived_framework.cpp 4003e47
src/examples/memhog.cpp 339d238
src/examples/python/test_framework.py e6893cf
src/examples/scheduled_memhog.cpp 5d01aef
src/java/jni/convert.cpp 04a25dd
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 8704663
src/java/src/org/apache/mesos/Scheduler.java 63a06fe
src/master/master.cpp ede831e
src/messages/messages.proto a9cbcdc
src/python/native/proxy_scheduler.hpp a348cbb
src/python/native/proxy_scheduler.cpp 934820a
src/python/src/mesos.py 5fc60e2
src/sched/sched.cpp 7f4e980
src/tests/exception_tests.cpp 62f4fb6
src/tests/fault_tolerance_tests.cpp ebb7709
src/tests/master_tests.cpp a1f5007
src/tests/resource_offers_tests.cpp 8e1061e
src/tests/utils.hpp 65ce4df
Diff: https://reviews.apache.org/r/3083/diff
Testing
-------
./bin/tests/all-tests
Thanks,
Vinod
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239133#comment-13239133 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/#review6395
-----------------------------------------------------------
Ship it!
Thanks Vinod! I know Matei really wanted these in before the release so this is great!
src/examples/java/TestExceptionFramework.java
<https://reviews.apache.org/r/3083/#comment13955>
Wrap.
src/examples/java/TestFramework.java
<https://reviews.apache.org/r/3083/#comment13956>
Wrap.
src/examples/java/TestMultipleExecutorsFramework.java
<https://reviews.apache.org/r/3083/#comment13957>
Wrap.
src/examples/long_lived_framework.cpp
<https://reviews.apache.org/r/3083/#comment13952>
Don't you want to reorganize these? ;) (And elsewhere.)
src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/3083/#comment13953>
Awesome!
src/java/jni/convert.cpp
<https://reviews.apache.org/r/3083/#comment13958>
Not used, please kill.
src/java/src/org/apache/mesos/Scheduler.java
<https://reviews.apache.org/r/3083/#comment13959>
Put on previous line.
src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/3083/#comment13960>
Ugh. ;)
src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/3083/#comment13961>
Indentation.
- Benjamin
On 2012-03-27 01:25:17, Vinod Kone wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3083/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-27 01:25:17)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and John Sirois.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. New Scheduler callbacks for master info (ip and port)
bq.
bq. --> registered() callback now includes maste info
bq. --> new re-registered() callback is called when a new master is elected
bq. --> new masterLost() callback is called when mesos core doesnt detect an
bq. active master (e.g: during election)
bq. --> new executorLost() callback
bq.
bq. New Executor callbacks
bq. --> reregistered() callback
bq. --> slaveLost() callback
bq.
bq.
bq. This addresses bug MESOS-86.
bq. https://issues.apache.org/jira/browse/MESOS-86
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. include/mesos/executor.hpp ef7bdf9
bq. include/mesos/scheduler.hpp 5bcf065
bq. src/common/values.cpp 09d162f
bq. src/examples/java/TestExceptionFramework.java d15b132
bq. src/examples/java/TestFramework.java f86646b
bq. src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
bq. src/examples/long_lived_executor.cpp 4b4abad
bq. src/examples/long_lived_framework.cpp 2775f5a
bq. src/examples/no_executor_framework.cpp fb31b25
bq. src/examples/python/test_framework.py 0d71831
bq. src/examples/test_executor.cpp ba54004
bq. src/examples/test_framework.cpp 622f6ac
bq. src/java/jni/convert.cpp 5c2bf21
bq. src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe
bq. src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b
bq. src/java/src/org/apache/mesos/Scheduler.java b01468b
bq. src/launcher/executor.cpp da4203c
bq. src/master/master.cpp 6110c17
bq. src/messages/messages.proto 7f9cffe
bq. src/python/native/proxy_executor.hpp 32df90b
bq. src/python/native/proxy_executor.cpp d453406
bq. src/python/native/proxy_scheduler.hpp d0e5dfd
bq. src/python/native/proxy_scheduler.cpp 9717f44
bq. src/python/src/mesos.py 25d762b
bq. src/sched/sched.cpp 9440381
bq. src/tests/exception_tests.cpp c14bacc
bq. src/tests/fault_tolerance_tests.cpp 9e7d181
bq. src/tests/master_tests.cpp 57db468
bq. src/tests/resource_offers_tests.cpp a405888
bq. src/tests/utils.hpp 9241567
bq.
bq. Diff: https://reviews.apache.org/r/3083/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Vinod
bq.
bq.
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169878#comment-13169878 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/#review3917
-----------------------------------------------------------
src/java/jni/convert.cpp
<https://reviews.apache.org/r/3083/#comment8806>
I see this got added, but it's not used? I know in a previous review (internal) I had suggested this ... did the rest of the code that was part of it get dropped? If so, we should drop this too.
- Benjamin
On 2011-12-09 02:41:32, Vinod Kone wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3083/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-09 02:41:32)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and John Sirois.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. New Scheduler callbacks for master info (ip and port)
bq.
bq. --> registered() callback now includes maste info
bq. --> new re-registered() callback is called when a new master is elected
bq. --> new masterLost() callback is called when mesos core doesnt detect an
bq. active master (e.g: during election)
bq.
bq.
bq. This addresses bug MESOS-86.
bq. https://issues.apache.org/jira/browse/MESOS-86
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. include/mesos/scheduler.hpp 93dda98
bq. src/examples/cpp_test_framework.cpp ab02805
bq. src/examples/java/TestExceptionFramework.java ba39757
bq. src/examples/java/TestFramework.java e1b6032
bq. src/examples/java/TestMultipleExecutorsFramework.java a49ecbb
bq. src/examples/long_lived_framework.cpp 4003e47
bq. src/examples/memhog.cpp 339d238
bq. src/examples/python/test_framework.py e6893cf
bq. src/examples/scheduled_memhog.cpp 5d01aef
bq. src/java/jni/convert.cpp 04a25dd
bq. src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 8704663
bq. src/java/src/org/apache/mesos/Scheduler.java 63a06fe
bq. src/master/master.cpp ede831e
bq. src/messages/messages.proto a9cbcdc
bq. src/python/native/proxy_scheduler.hpp a348cbb
bq. src/python/native/proxy_scheduler.cpp 934820a
bq. src/python/src/mesos.py 5fc60e2
bq. src/sched/sched.cpp 7f4e980
bq. src/tests/exception_tests.cpp 62f4fb6
bq. src/tests/fault_tolerance_tests.cpp ebb7709
bq. src/tests/master_tests.cpp a1f5007
bq. src/tests/resource_offers_tests.cpp 8e1061e
bq. src/tests/utils.hpp 65ce4df
bq.
bq. Diff: https://reviews.apache.org/r/3083/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ./bin/tests/all-tests
bq.
bq.
bq. Thanks,
bq.
bq. Vinod
bq.
bq.
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "Vinod Kone (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155985#comment-13155985 ]
Vinod Kone commented on MESOS-86:
---------------------------------
hey sumedh...wanted to let u know that i've already begun (almost finished!) work on this and its currently going through review feedback.
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Sumedh Sawant
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MESOS-86) Expose master url to the scheduler
Posted by "Andy Konwinski (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Konwinski reassigned MESOS-86:
-----------------------------------
Assignee: Vinod Kone (was: Sumedh Sawant)
Hey Vinod,
Super glad to hear you're working on this! I'm reassigning this from Sumedh to you.
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "Vinod Kone (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155984#comment-13155984 ]
Vinod Kone commented on MESOS-86:
---------------------------------
hey sumedh...wanted to let u know that i've already begun (almost finished!) work on this and its currently going through review feedback.
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Sumedh Sawant
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172553#comment-13172553 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
bq. On 2011-12-15 00:30:09, Benjamin Hindman wrote:
bq. > src/java/jni/convert.cpp, line 49
bq. > <https://reviews.apache.org/r/3083/diff/1/?file=63411#file63411line49>
bq. >
bq. > I see this got added, but it's not used? I know in a previous review (internal) I had suggested this ... did the rest of the code that was part of it get dropped? If so, we should drop this too.
hmm..looks like a bad diff merge...let me get the correct diff
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/#review3917
-----------------------------------------------------------
On 2011-12-09 02:41:32, Vinod Kone wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3083/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-09 02:41:32)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and John Sirois.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. New Scheduler callbacks for master info (ip and port)
bq.
bq. --> registered() callback now includes maste info
bq. --> new re-registered() callback is called when a new master is elected
bq. --> new masterLost() callback is called when mesos core doesnt detect an
bq. active master (e.g: during election)
bq.
bq.
bq. This addresses bug MESOS-86.
bq. https://issues.apache.org/jira/browse/MESOS-86
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. include/mesos/scheduler.hpp 93dda98
bq. src/examples/cpp_test_framework.cpp ab02805
bq. src/examples/java/TestExceptionFramework.java ba39757
bq. src/examples/java/TestFramework.java e1b6032
bq. src/examples/java/TestMultipleExecutorsFramework.java a49ecbb
bq. src/examples/long_lived_framework.cpp 4003e47
bq. src/examples/memhog.cpp 339d238
bq. src/examples/python/test_framework.py e6893cf
bq. src/examples/scheduled_memhog.cpp 5d01aef
bq. src/java/jni/convert.cpp 04a25dd
bq. src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 8704663
bq. src/java/src/org/apache/mesos/Scheduler.java 63a06fe
bq. src/master/master.cpp ede831e
bq. src/messages/messages.proto a9cbcdc
bq. src/python/native/proxy_scheduler.hpp a348cbb
bq. src/python/native/proxy_scheduler.cpp 934820a
bq. src/python/src/mesos.py 5fc60e2
bq. src/sched/sched.cpp 7f4e980
bq. src/tests/exception_tests.cpp 62f4fb6
bq. src/tests/fault_tolerance_tests.cpp ebb7709
bq. src/tests/master_tests.cpp a1f5007
bq. src/tests/resource_offers_tests.cpp 8e1061e
bq. src/tests/utils.hpp 65ce4df
bq.
bq. Diff: https://reviews.apache.org/r/3083/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ./bin/tests/all-tests
bq.
bq.
bq. Thanks,
bq.
bq. Vinod
bq.
bq.
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-86) Expose master url to the scheduler
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239264#comment-13239264 ]
jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------
(Updated 2012-03-27 07:06:42.783287)
Review request for mesos, Benjamin Hindman and John Sirois.
Changes
-------
new executor registered and reregistered callbacks.
Summary
-------
New Scheduler callbacks for master info (ip and port)
--> registered() callback now includes maste info
--> new re-registered() callback is called when a new master is elected
--> new masterLost() callback is called when mesos core doesnt detect an
active master (e.g: during election)
--> new executorLost() callback
New Executor callbacks
--> reregistered() callback
--> slaveLost() callback
This addresses bug MESOS-86.
https://issues.apache.org/jira/browse/MESOS-86
Diffs (updated)
-----
include/mesos/executor.hpp ef7bdf9
include/mesos/mesos.proto 23aad17
include/mesos/scheduler.hpp 5bcf065
src/common/values.cpp 09d162f
src/examples/java/TestExceptionFramework.java d15b132
src/examples/java/TestExecutor.java f57cda4
src/examples/java/TestFramework.java f86646b
src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
src/examples/long_lived_executor.cpp 4b4abad
src/examples/long_lived_framework.cpp 2775f5a
src/examples/no_executor_framework.cpp fb31b25
src/examples/python/test_framework.py 0d71831
src/examples/test_executor.cpp ba54004
src/examples/test_framework.cpp 622f6ac
src/exec/exec.cpp 060707ad
src/java/jni/convert.cpp 5c2bf21
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b
src/java/src/org/apache/mesos/Executor.java 3db3068
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 129a108
src/java/src/org/apache/mesos/Scheduler.java b01468b
src/java/src/org/apache/mesos/SchedulerDriver.java 0638ee3
src/launcher/executor.cpp da4203c
src/master/master.cpp 6110c17
src/messages/messages.proto 7f9cffe
src/python/native/mesos_scheduler_driver_impl.cpp 9e088ef
src/python/native/proxy_executor.hpp 32df90b
src/python/native/proxy_executor.cpp d453406
src/python/native/proxy_scheduler.hpp d0e5dfd
src/python/native/proxy_scheduler.cpp 9717f44
src/python/src/mesos.py 25d762b
src/scaling/nested_exec.py 9625953
src/sched/sched.cpp 9440381
src/tests/exception_tests.cpp c14bacc
src/tests/fault_tolerance_tests.cpp 9e7d181
src/tests/master_tests.cpp 57db468
src/tests/resource_offers_tests.cpp a405888
src/tests/utils.hpp 9241567
Diff: https://reviews.apache.org/r/3083/diff
Testing (updated)
-------
make check success except PythonFramework test
Thanks,
Vinod
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira