[GitHub] [incubator-teaclave-trustzone-sdk] DemesneGH commented on a change in pull request #29: Add support for tee-supplicant loadable plugins

[GitBox <gi...@apache.org>]

DemesneGH commented on a change in pull request #29:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/29#discussion_r656819230



##########
File path: examples/supp_plugin/plugin/plugin_static.rs
##########
@@ -0,0 +1,27 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#[no_mangle]
+pub static mut plugin_method: PluginMethod = PluginMethod {

Review comment:
       After removing the `mut`, this error occurs: 
   ```
   error[E0277]: `*mut u8` cannot be shared between threads safely.
     = help: within `optee_teec::extension::PluginMethod`, the trait `std::marker::Sync` is not implemented for `*mut u8`
      = note: required because it appears within the type `optee_teec::extension::PluginMethod`
      = note: shared static variables must have a type that implements `Sync`
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org