You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/04/12 07:49:53 UTC
Review Request 46071: GEODE-1213: Disables signing task on
geode-modules-assembly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46071/
-----------------------------------------------------------
Review request for geode, Jens Deppe, Mark Bretl, and Dan Smith.
Repository: geode
Description
-------
The signArchives task was not getting disabled on geode-modules-
assembly project. This was causing a build error since the
project did not generate a jar artifact. This error was only
seen when enabling signing by setting properties in your
~/.gradle/gradle.properties file.
Diffs
-----
gradle/utilities.gradle 6a6df048c76e6d8e15c6fed77aa94c50f5ab7f1c
Diff: https://reviews.apache.org/r/46071/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 46071: GEODE-1213: Disables signing task on
geode-modules-assembly
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46071/#review128455
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Bretl
On April 11, 2016, 10:49 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46071/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 10:49 p.m.)
>
>
> Review request for geode, Jens Deppe, Mark Bretl, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The signArchives task was not getting disabled on geode-modules-
> assembly project. This was causing a build error since the
> project did not generate a jar artifact. This error was only
> seen when enabling signing by setting properties in your
> ~/.gradle/gradle.properties file.
>
>
> Diffs
> -----
>
> gradle/utilities.gradle 6a6df048c76e6d8e15c6fed77aa94c50f5ab7f1c
>
> Diff: https://reviews.apache.org/r/46071/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 46071: GEODE-1213: Disables signing task on
geode-modules-assembly
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46071/#review128387
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On April 12, 2016, 5:49 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46071/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 5:49 a.m.)
>
>
> Review request for geode, Jens Deppe, Mark Bretl, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The signArchives task was not getting disabled on geode-modules-
> assembly project. This was causing a build error since the
> project did not generate a jar artifact. This error was only
> seen when enabling signing by setting properties in your
> ~/.gradle/gradle.properties file.
>
>
> Diffs
> -----
>
> gradle/utilities.gradle 6a6df048c76e6d8e15c6fed77aa94c50f5ab7f1c
>
> Diff: https://reviews.apache.org/r/46071/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 46071: GEODE-1213: Disables signing task on
geode-modules-assembly
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46071/#review128451
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On April 12, 2016, 5:49 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46071/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 5:49 a.m.)
>
>
> Review request for geode, Jens Deppe, Mark Bretl, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The signArchives task was not getting disabled on geode-modules-
> assembly project. This was causing a build error since the
> project did not generate a jar artifact. This error was only
> seen when enabling signing by setting properties in your
> ~/.gradle/gradle.properties file.
>
>
> Diffs
> -----
>
> gradle/utilities.gradle 6a6df048c76e6d8e15c6fed77aa94c50f5ab7f1c
>
> Diff: https://reviews.apache.org/r/46071/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>