[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7421: NIFI-11739: Add ability to ignore missing fields in PutIceberg

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory commented on code in PR #7421:
URL: https://github.com/apache/nifi/pull/7421#discussion_r1242475244


##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/test/java/org/apache/nifi/processors/iceberg/TestIcebergRecordConverter.java:
##########
@@ -473,6 +516,103 @@ public void testPrimitives(FileFormat format) throws IOException {
         }
     }
 
+    @DisabledOnOs(WINDOWS)
+    @ParameterizedTest
+    @EnumSource(value = FileFormat.class, names = {"AVRO", "ORC", "PARQUET"})

Review Comment:
   One general note on these tests, it it probably worth avoiding some of the repeated tests in the interest of execution time. Several other tests ran through all formats, requiring over a minute to exercise all cases. Keeping unit test method runs under a second would be ideal, so these new tests may need to be more narrowly scoped to avoid excessive running time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org