You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sachchidanand Vaidya <va...@juniper.net> on 2014/05/01 01:15:32 UTC
Re: Review Request 19892: Add Juniper Contrail support to devCloud
environment
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19892/
-----------------------------------------------------------
(Updated April 30, 2014, 4:15 p.m.)
Review request for cloudstack.
Changes
-------
Thanks Daan. I have updated the diff based on latest code on Master. Also taken care of review comment.
Regards,
Sachin
Repository: cloudstack-git
Description
-------
Add OpenContrail support to devCloud environment:
- Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg).
- Modification to deployDataCenter script, to enable "JuniperContrailRouter" &
"JuniperContrailVpcRouter" providers.
Diffs (updated)
-----
tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION
tools/marvin/marvin/deployDataCenter.py 31f663e
Diff: https://reviews.apache.org/r/19892/diff/
Testing
-------
Unit tested with devCloud2 and ACS4.3 code base.
Thanks,
Sachchidanand Vaidya
Re: Review Request 19892: Add Juniper Contrail support to devCloud
environment
Posted by Sachchidanand Vaidya <va...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19892/
-----------------------------------------------------------
(Updated May 2, 2014, 5:23 p.m.)
Review request for cloudstack.
Changes
-------
Uploading diff based off ACS4.4 code base.
Repository: cloudstack-git
Description
-------
Add OpenContrail support to devCloud environment:
- Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg).
- Modification to deployDataCenter script, to enable "JuniperContrailRouter" &
"JuniperContrailVpcRouter" providers.
Diffs (updated)
-----
tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION
tools/marvin/marvin/deployDataCenter.py c4f6e1e
Diff: https://reviews.apache.org/r/19892/diff/
Testing
-------
Unit tested with devCloud2 and ACS4.3 code base.
Thanks,
Sachchidanand Vaidya
Re: Review Request 19892: Add Juniper Contrail support to devCloud
environment
Posted by Sachchidanand Vaidya <va...@juniper.net>.
Hi Daan,
I uploaded a diff (ACS4.4-0004-Add-OpenContrail-support-to-devCloud-environment.patch) based on ACS4.4 code base.
Thanks,
Sachin
From: Daan Hoogland <da...@gmail.com>>
Date: Friday, May 2, 2014 11:03 AM
To: Sachchidanand Vaidya <va...@juniper.net>>
Cc: cloudstack <de...@cloudstack.apache.org>>
Subject: Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
It doesn't cherry-pick cleaanly. Can you have a look?
On Thu, May 1, 2014 at 7:38 PM, Sachchidanand Vaidya <va...@juniper.net>> wrote:
Thanks Daan. Can it be committed to 4.4 as well.
Best Regards,
Sachin
From: daan Hoogland <da...@gmail.com>>
Reply-To: daan Hoogland <da...@gmail.com>>
Date: Thursday, May 1, 2014 4:11 AM
To: daan Hoogland <da...@gmail.com>>, Sachchidanand Vaidya <va...@juniper.net>>, cloudstack <de...@cloudstack.apache.org>>
Subject: Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19892/
Ship it!
537536835bfe5161946fbc83675b4a4696536949
- daan Hoogland
On April 30th, 2014, 11:15 p.m. UTC, Sachchidanand Vaidya wrote:
Review request for cloudstack.
By Sachchidanand Vaidya.
Updated April 30, 2014, 11:15 p.m.
Repository: cloudstack-git
Description
Add OpenContrail support to devCloud environment:
- Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg).
- Modification to deployDataCenter script, to enable "JuniperContrailRouter" &
"JuniperContrailVpcRouter" providers.
Testing
Unit tested with devCloud2 and ACS4.3 code base.
Diffs
* tools/devcloud/devcloud-advanced_juniper-contrail.cfg (PRE-CREATION)
* tools/marvin/marvin/deployDataCenter.py (31f663e)
View Diff<https://reviews.apache.org/r/19892/diff/>
--
Daan
Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
Posted by Daan Hoogland <da...@gmail.com>.
It doesn't cherry-pick cleaanly. Can you have a look?
On Thu, May 1, 2014 at 7:38 PM, Sachchidanand Vaidya
<va...@juniper.net>wrote:
> Thanks Daan. Can it be committed to 4.4 as well.
>
> Best Regards,
> Sachin
>
> From: daan Hoogland <da...@gmail.com>
> Reply-To: daan Hoogland <da...@gmail.com>
> Date: Thursday, May 1, 2014 4:11 AM
> To: daan Hoogland <da...@gmail.com>, Sachchidanand Vaidya <
> vaidyasd@juniper.net>, cloudstack <de...@cloudstack.apache.org>
> Subject: Re: Review Request 19892: Add Juniper Contrail support to
> devCloud environment
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19892/
>
> Ship it!
>
> 537536835bfe5161946fbc83675b4a4696536949
>
>
> - daan Hoogland
>
> On April 30th, 2014, 11:15 p.m. UTC, Sachchidanand Vaidya wrote:
> Review request for cloudstack.
> By Sachchidanand Vaidya.
>
> *Updated April 30, 2014, 11:15 p.m.*
> *Repository: *cloudstack-git
> Description
>
> Add OpenContrail support to devCloud environment:
> - Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg).
> - Modification to deployDataCenter script, to enable "JuniperContrailRouter" &
> "JuniperContrailVpcRouter" providers.
>
> Testing
>
> Unit tested with devCloud2 and ACS4.3 code base.
>
> Diffs
>
> - tools/devcloud/devcloud-advanced_juniper-contrail.cfg (PRE-CREATION)
> - tools/marvin/marvin/deployDataCenter.py (31f663e)
>
> View Diff <https://reviews.apache.org/r/19892/diff/>
>
--
Daan
Re: Review Request 19892: Add Juniper Contrail support to devCloud
environment
Posted by Sachchidanand Vaidya <va...@juniper.net>.
Thanks Daan. Can it be committed to 4.4 as well.
Best Regards,
Sachin
From: daan Hoogland <da...@gmail.com>>
Reply-To: daan Hoogland <da...@gmail.com>>
Date: Thursday, May 1, 2014 4:11 AM
To: daan Hoogland <da...@gmail.com>>, Sachchidanand Vaidya <va...@juniper.net>>, cloudstack <de...@cloudstack.apache.org>>
Subject: Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19892/
Ship it!
537536835bfe5161946fbc83675b4a4696536949
- daan Hoogland
On April 30th, 2014, 11:15 p.m. UTC, Sachchidanand Vaidya wrote:
Review request for cloudstack.
By Sachchidanand Vaidya.
Updated April 30, 2014, 11:15 p.m.
Repository: cloudstack-git
Description
Add OpenContrail support to devCloud environment:
- Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg).
- Modification to deployDataCenter script, to enable "JuniperContrailRouter" &
"JuniperContrailVpcRouter" providers.
Testing
Unit tested with devCloud2 and ACS4.3 code base.
Diffs
* tools/devcloud/devcloud-advanced_juniper-contrail.cfg (PRE-CREATION)
* tools/marvin/marvin/deployDataCenter.py (31f663e)
View Diff<https://reviews.apache.org/r/19892/diff/>
Re: Review Request 19892: Add Juniper Contrail support to devCloud
environment
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19892/#review41914
-----------------------------------------------------------
Ship it!
537536835bfe5161946fbc83675b4a4696536949
- daan Hoogland
On April 30, 2014, 11:15 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19892/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 11:15 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add OpenContrail support to devCloud environment:
> - Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg).
> - Modification to deployDataCenter script, to enable "JuniperContrailRouter" &
> "JuniperContrailVpcRouter" providers.
>
>
> Diffs
> -----
>
> tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION
> tools/marvin/marvin/deployDataCenter.py 31f663e
>
> Diff: https://reviews.apache.org/r/19892/diff/
>
>
> Testing
> -------
>
> Unit tested with devCloud2 and ACS4.3 code base.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>