You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by parthchandra <gi...@git.apache.org> on 2017/10/13 22:05:41 UTC
[GitHub] drill pull request #992: DRILL-5873: (C++ Client) Improve SASL error reporti...
GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/992
DRILL-5873: (C++ Client) Improve SASL error reporting.
@sohami what do you think? I overrode the SASL_NOMECH error message. The message from the SASL library is very unfriendly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/parthchandra/drill DRILL-5873
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #992
----
commit 31e71147c37a7e37348dfae323d894114204c8dd
Author: Parth Chandra <pa...@apache.org>
Date: 2017-10-13T18:00:31Z
DRILL-5873: (C++ Client) Improve SASL error reporting.
----
---
[GitHub] drill issue #992: DRILL-5873: (C++ Client) Improve SASL error reporting.
Posted by sohami <gi...@git.apache.org>.
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/992
+1 LGTM. Thanks a lot for the changes.
---
[GitHub] drill pull request #992: DRILL-5873: (C++ Client) Improve SASL error reporti...
Posted by sohami <gi...@git.apache.org>.
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/992#discussion_r144977545
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -678,7 +678,10 @@ connectionStatus_t DrillClientImpl::handleAuthentication(const DrillUserProperti
m_io_service.reset();
return CONN_SUCCESS;
} else {
- logMsg << m_encryptionCtxt << ", Error: " << m_saslResultCode;
+ logMsg << m_encryptionCtxt
+ << ", Mechanism: " << m_saslAuthenticator->getAuthMechanismName()
+ << ", Error: " << m_saslResultCode
+ << ", Cause: " << m_saslAuthenticator->getErrorMessage(m_saslResultCode);
--- End diff --
How about adding this cause message string in the [if condition](https://github.com/apache/drill/pull/992/files#diff-8e6df071d8ca863fcfa578892944c1dcR661) too ?
---
[GitHub] drill issue #992: DRILL-5873: (C++ Client) Improve SASL error reporting.
Posted by superbstreak <gi...@git.apache.org>.
Github user superbstreak commented on the issue:
https://github.com/apache/drill/pull/992
@parthchandra Thanks for adding this!
---
[GitHub] drill pull request #992: DRILL-5873: (C++ Client) Improve SASL error reporti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/992
---