You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "WangGuangxin (via GitHub)" <gi...@apache.org> on 2024/04/17 23:47:49 UTC
[PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
WangGuangxin opened a new pull request, #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442
## What changes were proposed in this pull request?
A minor change to make the `maxBatchSize` consistent with the check in `VeloxShuffleWriter`
https://github.com/apache/incubator-gluten/blob/main/cpp/velox/shuffle/VeloxShuffleWriter.cc#L222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
Posted by "marin-ma (via GitHub)" <gi...@apache.org>.
marin-ma commented on code in PR #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442#discussion_r1569912522
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -481,10 +481,10 @@ object BackendSettings extends BackendSettingsApi {
private def checkMaxBatchSize(nativeConf: java.util.Map[String, String]): Unit = {
if (nativeConf.containsKey(GlutenConfig.GLUTEN_MAX_BATCH_SIZE_KEY)) {
val maxBatchSize = nativeConf.get(GlutenConfig.GLUTEN_MAX_BATCH_SIZE_KEY).toInt
- if (maxBatchSize > MAXIMUM_BATCH_SIZE) {
+ if (maxBatchSize >= MAXIMUM_BATCH_SIZE) {
Review Comment:
The check in native shuffle writer requires the split buffer (aka. output batch size from shuffle writer) <= 32k, which means the maximum batch size in the pipeline can equal to 32k. But this change makes the maximum batch size < 32k.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
Posted by "WangGuangxin (via GitHub)" <gi...@apache.org>.
WangGuangxin commented on code in PR #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442#discussion_r1570575798
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -481,10 +481,10 @@ object BackendSettings extends BackendSettingsApi {
private def checkMaxBatchSize(nativeConf: java.util.Map[String, String]): Unit = {
if (nativeConf.containsKey(GlutenConfig.GLUTEN_MAX_BATCH_SIZE_KEY)) {
val maxBatchSize = nativeConf.get(GlutenConfig.GLUTEN_MAX_BATCH_SIZE_KEY).toInt
- if (maxBatchSize > MAXIMUM_BATCH_SIZE) {
+ if (maxBatchSize >= MAXIMUM_BATCH_SIZE) {
Review Comment:
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
Posted by "WangGuangxin (via GitHub)" <gi...@apache.org>.
WangGuangxin closed pull request #5442: [VL] Make the maxBatchSize check consistent
URL: https://github.com/apache/incubator-gluten/pull/5442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442#issuecomment-2062710897
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
Posted by "WangGuangxin (via GitHub)" <gi...@apache.org>.
WangGuangxin commented on PR #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442#issuecomment-2062831381
cc @marin-ma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
Posted by "marin-ma (via GitHub)" <gi...@apache.org>.
marin-ma commented on PR #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442#issuecomment-2062897985
@FelixYBW Should we completely remove the batch size limitation on both java and native code as https://github.com/apache/incubator-gluten/pull/5326 has been merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on PR #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442#issuecomment-2062899445
> @FelixYBW Should we completely remove the batch size limitation on both java and native code as #5326 has been merged?
Yes, let's comment it and marked as issue to be solved in Velox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Make the maxBatchSize check consistent [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on code in PR #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442#discussion_r1571045799
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -481,10 +481,10 @@ object BackendSettings extends BackendSettingsApi {
private def checkMaxBatchSize(nativeConf: java.util.Map[String, String]): Unit = {
if (nativeConf.containsKey(GlutenConfig.GLUTEN_MAX_BATCH_SIZE_KEY)) {
val maxBatchSize = nativeConf.get(GlutenConfig.GLUTEN_MAX_BATCH_SIZE_KEY).toInt
- if (maxBatchSize > MAXIMUM_BATCH_SIZE) {
+ if (maxBatchSize >= MAXIMUM_BATCH_SIZE) {
Review Comment:
@marin-ma we should remove the check here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org