You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/24 15:56:40 UTC
[GitHub] [airflow] jayantsande25 opened a new issue #17815: Missing example for Salesforce DAG
jayantsande25 opened a new issue #17815:
URL: https://github.com/apache/airflow/issues/17815
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
**Description**
airflow/providers/salesforce/example_dags/__init__.py
Missing example of Salesforce DAG ( rest api, bulk api)
**Use case / motivation**
An example DAG on how to query(select), Update, Delete salesforce object using Rest API and Bulk APIs
**Are you willing to submit a PR?**
May be later , after one basic example
<!--- We accept contributions! -->
**Related Issues**
None
<!-- Is there currently another issue associated with this? -->
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SCrocky commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
SCrocky commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-939275397
Yes, my bad, I'll upload a proposal this weekend.
Thanks for the reminder. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jayantsande25 commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
jayantsande25 commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-904767709
@xinbinhuang issue created for salesforce DAG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-912403047
Go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jayantsande25 commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
jayantsande25 commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-939274421
I guess no one is working on example DAGs for salesforce APIs yet.
On Thu, Oct 7, 2021 at 8:39 AM eladkal ***@***.***> wrote:
> @SCrocky <https://github.com/SCrocky> are you still working on this issue?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/issues/17815#issuecomment-937535001>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB4MRP5RNSFJRXXLKHTU6TTUFVFDDANCNFSM5CXEWGJA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jayantsande25 commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
jayantsande25 commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-1045981977
Yes Rachana
You're understanding is correct.
In case you need more information please let me know, we can discuss
On Sat, 19 Feb 2022, 12:35 Rachana Gogate, ***@***.***> wrote:
> I would like to take a pass at this.
>
> Can you confirm if my understanding is correct?
>
> 1. Salesforce Apex example dag
> <https://github.com/apache/airflow/blob/0a3ff43d41d33d05fb3996e61785919effa9a2fa/airflow/providers/salesforce/example_dags/example_salesforce_apex_rest.py>
> has just one example to POST activity data. More example dags are possible
> here given the flexibility of the Operator.
> 2. We don't have a Salesforce Bulk or similar operator. We would like
> to add that and corresponding examples.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/issues/17815#issuecomment-1045917987>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB4MRPZMN5T52ZKDKOODWCLU346NHANCNFSM5CXEWGJA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SCrocky commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
SCrocky commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-912474018
> Tableau used to be in Salesforce provider. It was extracted to a seperated provider. To avoid breaking change we left the option to import tableau from Salesforce provider which will be removed eventually.
Backwards compatibility. Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-937535001
@SCrocky are you still working on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SCrocky commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
SCrocky commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-912432322
Can someone explain why the salesforce provider operator and sensor both contain tableau provider empty files?
Also the salesforce hook folder also has an empty tableau hook file in there.
I think they should've been deleted in commit [Add Tableau Provider Separate from Salesforce Provider](https://github.com/apache/airflow/commit/45e72ca83049a7db526b1f0fbd94c75f5f92cc75#diff-013f494aaae3dee1fbddedd59a9e7cac444b425f8432426e2f0467dc8c42f22b).
Should I delete them in my commit ?
Do I only use Salesforce hooks in my DAG example? No Sensors or Operators?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-937535001
@SCrocky are you still working on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rsg17 commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
rsg17 commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-1046508382
Sounds good. Will look at examples for existing code. (Will exclude bulk API related examples)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mrbazzan commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
mrbazzan commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-946135929
@SCrocky Are you still working on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-1045976042
@rsg17 The goal of examples is to show simple usage of the capabilities. It is not for suggesting workaround or how to complete missing functionality (Bulk is not yet supported https://github.com/apache/airflow/issues/16921 )
The easiest way to do it is simple go over the provider abilities and add example where missing. If you find the examples we have satisfactory we can close this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SCrocky commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
SCrocky commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-912398003
I'm starting contributing.
Can I take this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SCrocky edited a comment on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
SCrocky edited a comment on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-912432322
Can someone explain why the `providers/salesforce` folders: operator and sensor, both contain `providers/tableau` empty files?
Also the salesforce hook folder also has an empty tableau hook file in there.
I think they should've been deleted in commit [Add Tableau Provider Separate from Salesforce Provider](https://github.com/apache/airflow/commit/45e72ca83049a7db526b1f0fbd94c75f5f92cc75#diff-013f494aaae3dee1fbddedd59a9e7cac444b425f8432426e2f0467dc8c42f22b).
Should I delete them in my commit ?
Do I only use Salesforce hooks in my DAG example? No Sensors or Operators?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-904766619
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-912472025
> Can someone explain why the `providers/salesforce` folders: operator and sensor, both contain `providers/tableau` empty files?
Tableau used to be in Salesforce provider. It was extracted to a seperated provider. To avoid breaking change we left the option to import tableau from Salesforce provider which will be removed eventually.
You can ignore the tableau folder in the salesforce provider. If you wish to add examples for tableau add them to the Tableau provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rsg17 commented on issue #17815: Missing example for Salesforce DAG
Posted by GitBox <gi...@apache.org>.
rsg17 commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-1045917987
I would like to take a pass at this.
Can you confirm if my understanding is correct?
1. Salesforce Apex [example dag ](https://github.com/apache/airflow/blob/0a3ff43d41d33d05fb3996e61785919effa9a2fa/airflow/providers/salesforce/example_dags/example_salesforce_apex_rest.py) has just one example to POST activity data. More example dags are possible here given the flexibility of the Operator.
2. We don't have a Salesforce Bulk or similar operator. We would like to add that and corresponding examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org