You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2020/10/10 16:18:25 UTC

[Bug 64797] New: Align manager.xml template file in Host-Manager with context.xml of real Manager web application.

https://bz.apache.org/bugzilla/show_bug.cgi?id=64797

            Bug ID: 64797
           Summary: Align manager.xml template file in Host-Manager with
                    context.xml of real Manager web application.
           Product: Tomcat 10
           Version: 10.0.0-M9
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Manager
          Assignee: dev@tomcat.apache.org
          Reporter: knst.kolinko@gmail.com
  Target Milestone: ------

In Host Manager there is a file "manager.xml". It is used to configure an copy
of Manager webapp when a new virtual host is created via Host Manager.

As time goes, it became different from a META-INF/context.xml file of a real
Manager application.

E.g. the following commit added a CookieProcessor configuration to the Manager
web application, but "manager.xml" file has not been updated.

https://github.com/apache/tomcat/commit/3405dec9efb027252ddba005d6e44dda4c9f43df

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64797] Align manager.xml template file in Host-Manager with context.xml of real Manager web application.

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64797

--- Comment #3 from Igal Sapir <is...@apache.org> ---
Please see
https://github.com/apache/tomcat/commit/04c7bf00144e38c7b1128e4bb5fed310a1ccfec8

I like the idea of renaming to "manager-template.xml"m as well as your answer
to my question, but only saw your comment now.

I'd be happy to make changes as needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64797] Align manager.xml template file in Host-Manager with context.xml of real Manager web application.

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64797

--- Comment #2 from Konstantin Kolinko <kn...@gmail.com> ---
(In reply to Igal Sapir from comment #1)
> Would it make sense to copy webapps/manager/META-INF/context.xml to
> webapps/host-manager/manager.xml as part of the build script (i.e. in
> build.xml)?

That is a good idea, but note the differences:

- An attribute docBase="${catalina.home}/webapps/manager"
- A comment at the top.

Both can be inserted while copying.

https://ant.apache.org/manual-1.9.x/Types/filterchain.html#replaceregex
https://ant.apache.org/manual-1.9.x/Tasks/copy.html


I wonder whether there can be a better name for this file, to clarify its
purpose. E.g. "manager-template.xml". Though that is a separate issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64797] Align manager.xml template file in Host-Manager with context.xml of real Manager web application.

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64797

Igal Sapir <is...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Igal Sapir <is...@apache.org> ---
Would it make sense to copy webapps/manager/META-INF/context.xml to
webapps/host-manager/manager.xml as part of the build script (i.e. in
build.xml)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64797] Align manager.xml template file in Host-Manager with context.xml of real Manager web application.

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64797

Igal Sapir <is...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Igal Sapir <is...@apache.org> ---
Ported to 9.0.x, 8.5.x, and 7.0.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org