You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by re...@apache.org on 2007/03/14 09:35:07 UTC
svn commit: r518067 - in
/cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util:
BlockCallHttpServletRequest.java BlockCallHttpServletResponse.java
Author: reinhard
Date: Wed Mar 14 01:35:07 2007
New Revision: 518067
URL: http://svn.apache.org/viewvc?view=rev&rev=518067
Log:
Java 5 problem?
Modified:
cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java
cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java
Modified: cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java
URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java?view=diff&rev=518067&r1=518066&r2=518067
==============================================================================
--- cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java (original)
+++ cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java Wed Mar 14 01:35:07 2007
@@ -130,7 +130,7 @@
try {
return dateFormat.parse(header).getTime();
} catch (ParseException e) {
- throw new IllegalArgumentException(e);
+ throw new RuntimeException(e);
}
}
Modified: cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java
URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java?view=diff&rev=518067&r1=518066&r2=518067
==============================================================================
--- cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java (original)
+++ cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java Wed Mar 14 01:35:07 2007
@@ -294,7 +294,7 @@
try {
return dateFormat.parse(header).getTime();
} catch (ParseException e) {
- throw new IllegalArgumentException(e);
+ throw new RuntimeException(e);
}
}
Re: svn commit: r518067 - in /cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util:
BlockCallHttpServletRequest.java BlockCallHttpServletResponse.java
Posted by Grzegorz Kossakowski <gk...@apache.org>.
Reinhard Poetz napisał(a):
>
> The IllegalArgumentException doesn't have a constructure that you can
> pass a Throwable:
>
> http://java.sun.com/j2se/1.4.2/docs/api/java/lang/IllegalArgumentException.html#IllegalArgumentException(java.lang.String)
>
>
> I guess it was added in Java 5 or 6. The best option to detect these
> kind of problems is using JDK 1.4 in your IDE.
>
Ah, thank for spotting this.
I'm not sure if I can use JDK 1.4 in my opensuse 10.2 easily while 1.6
is installed but I promise to be more careful in the future and find
some way of catching this kind of problems.
--
Grzegorz Kossakowski
Re: svn commit: r518067 - in /cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util:
BlockCallHttpServletRequest.java BlockCallHttpServletResponse.java
Posted by Reinhard Poetz <re...@apache.org>.
Grzegorz Kossakowski wrote:
> Reinhard Poetz napisał(a):
>> Grek, are you using Java 1.4 for development? I suppose not ;-)
> I use 1.6 actually.
>> Maybe it's better to throw some more meaningful exception than a
>> RuntimeException but I haven't had time to look into this case.
> I do not understand. What's I'm doing wrong here?
> I apologize for any trouble caused by my changes.
The IllegalArgumentException doesn't have a constructure that you can pass a
Throwable:
http://java.sun.com/j2se/1.4.2/docs/api/java/lang/IllegalArgumentException.html#IllegalArgumentException(java.lang.String)
I guess it was added in Java 5 or 6. The best option to detect these kind of
problems is using JDK 1.4 in your IDE.
--
Reinhard Pötz Independent Consultant, Trainer & (IT)-Coach
{Software Engineering, Open Source, Web Applications, Apache Cocoon}
web(log): http://www.poetz.cc
--------------------------------------------------------------------
Re: svn commit: r518067 - in /cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util:
BlockCallHttpServletRequest.java BlockCallHttpServletResponse.java
Posted by Grzegorz Kossakowski <gk...@apache.org>.
Reinhard Poetz napisał(a):
>
> Grek, are you using Java 1.4 for development? I suppose not ;-)
I use 1.6 actually.
>
> Maybe it's better to throw some more meaningful exception than a
> RuntimeException but I haven't had time to look into this case.
I do not understand. What's I'm doing wrong here?
I apologize for any trouble caused by my changes.
--
Grzegorz Kossakowski
Re: svn commit: r518067 - in /cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util:
BlockCallHttpServletRequest.java BlockCallHttpServletResponse.java
Posted by Reinhard Poetz <re...@apache.org>.
Grek, are you using Java 1.4 for development? I suppose not ;-)
Maybe it's better to throw some more meaningful exception than a
RuntimeException but I haven't had time to look into this case.
reinhard@apache.org wrote:
> Author: reinhard
> Date: Wed Mar 14 01:35:07 2007
> New Revision: 518067
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=518067
> Log:
> Java 5 problem?
>
> Modified:
> cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java
> cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java
>
> Modified: cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java
> URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java?view=diff&rev=518067&r1=518066&r2=518067
> ==============================================================================
> --- cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java (original)
> +++ cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java Wed Mar 14 01:35:07 2007
> @@ -130,7 +130,7 @@
> try {
> return dateFormat.parse(header).getTime();
> } catch (ParseException e) {
> - throw new IllegalArgumentException(e);
> + throw new RuntimeException(e);
> }
> }
>
>
> Modified: cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java
> URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java?view=diff&rev=518067&r1=518066&r2=518067
> ==============================================================================
> --- cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java (original)
> +++ cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletResponse.java Wed Mar 14 01:35:07 2007
> @@ -294,7 +294,7 @@
> try {
> return dateFormat.parse(header).getTime();
> } catch (ParseException e) {
> - throw new IllegalArgumentException(e);
> + throw new RuntimeException(e);
> }
> }
--
Reinhard Pötz Independent Consultant, Trainer & (IT)-Coach
{Software Engineering, Open Source, Web Applications, Apache Cocoon}
web(log): http://www.poetz.cc
--------------------------------------------------------------------