You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/29 20:18:55 UTC

[GitHub] [beam] guangstick commented on a change in pull request #12968: [BEAM-7195] Fix BQ BatchLoad not creating new tables issue

guangstick commented on a change in pull request #12968:
URL: https://github.com/apache/beam/pull/12968#discussion_r497018910



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteBundlesToFiles.java
##########
@@ -74,7 +74,7 @@
    * The result of the {@link WriteBundlesToFiles} transform. Corresponds to a single output file,
    * and encapsulates the table it is destined to as well as the file byte size.
    */
-  static final class Result<DestinationT> implements Serializable {
+  public static final class Result<DestinationT> implements Serializable {

Review comment:
       Open to use getter or use @AutoValue here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org