You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/09/13 13:29:33 UTC

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #364: OAK-9568 : Support custom osgi LeaseFailureHandler

stefan-egli commented on pull request #364:
URL: https://github.com/apache/jackrabbit-oak/pull/364#issuecomment-918192715


   > Can you please add a test? E.g. to DocumentNodeStoreServiceTest.
   
   added test cases at 0480ce80d8bdf3785f9d5081763fb0efecc39206 : testing the default case is a bit simplistic, as all it does it ensure an `UnsupportedOperationException` is thrown - which is due to the mocking framework in use doesn't support `bundle.stop()`. That's a bit weak - but then again, it would be quite some effort to boost up the mocking to just to ensure `bundle.stop()` does get called.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org