You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2018/05/10 01:14:11 UTC

[GitHub] spark pull request #21183: [SPARK-22210][ML] Add seed for LDA variationalTop...

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21183#discussion_r187216371
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala ---
    @@ -252,6 +252,15 @@ class LDASuite extends SparkFunSuite with MLlibTestSparkContext with DefaultRead
         val lda = new LDA()
         testEstimatorAndModelReadWrite(lda, dataset, LDASuite.allParamSettings,
           LDASuite.allParamSettings, checkModelData)
    +
    +    def checkModelDataWithDataset(model: LDAModel, model2: LDAModel,
    --- End diff --
    
    style: Please fix this to match other multi-line method headers.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org