You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "SingingBush (via GitHub)" <gi...@apache.org> on 2024/01/02 20:33:35 UTC
[PR] replace findbugs plugin with spotbugs plugin [commons-beanutils]
SingingBush opened a new pull request, #197:
URL: https://github.com/apache/commons-beanutils/pull/197
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace findbugs plugin with spotbugs plugin [commons-beanutils]
Posted by "SingingBush (via GitHub)" <gi...@apache.org>.
SingingBush commented on code in PR #197:
URL: https://github.com/apache/commons-beanutils/pull/197#discussion_r1442731004
##########
pom.xml:
##########
@@ -397,6 +397,7 @@
</configuration>
</plugin>
<plugin>
+ <groupId>org.apache.maven.plugins</groupId>
Review Comment:
no problem, fixing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace findbugs plugin with spotbugs plugin [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #197: replace findbugs plugin with spotbugs plugin
URL: https://github.com/apache/commons-beanutils/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace findbugs plugin with spotbugs plugin [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #197:
URL: https://github.com/apache/commons-beanutils/pull/197#discussion_r1439937462
##########
pom.xml:
##########
@@ -397,6 +397,7 @@
</configuration>
</plugin>
<plugin>
+ <groupId>org.apache.maven.plugins</groupId>
Review Comment:
Hello @SingingBush ,
Thank you for your PR.
Please keep your chanes to the minimum and focused. These types of changes are not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace findbugs plugin with spotbugs plugin [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #197:
URL: https://github.com/apache/commons-beanutils/pull/197#issuecomment-1894525599
Closing: Done in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] replace findbugs plugin with spotbugs plugin [commons-beanutils]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #197:
URL: https://github.com/apache/commons-beanutils/pull/197#issuecomment-1874569405
## [Codecov](https://app.codecov.io/gh/apache/commons-beanutils/pull/197?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`893fe40`)](https://app.codecov.io/gh/apache/commons-beanutils/commit/893fe4048f866bf061ff41defe62eb1cfdd79dc5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 65.32% compared to head [(`0ebf85e`)](https://app.codecov.io/gh/apache/commons-beanutils/pull/197?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 65.32%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #197 +/- ##
=========================================
Coverage 65.32% 65.32%
Complexity 1488 1488
=========================================
Files 105 105
Lines 5509 5509
Branches 1069 1069
=========================================
Hits 3599 3599
Misses 1451 1451
Partials 459 459
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-beanutils/pull/197?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org