You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by michaelandersen <gi...@git.apache.org> on 2015/10/23 15:27:09 UTC
[GitHub] cloudstack pull request: Fix template not ready error
GitHub user michaelandersen opened a pull request:
https://github.com/apache/cloudstack/pull/971
Fix template not ready error
Add wait for template download
Refactored template section of services
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandersen/cloudstack fix/loadbalancer-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/971.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #971
----
commit b95c8200e20e7a2bec369b2ba8b8c4fbbc71b0ca
Author: Michael Andersen <ma...@schubergphilis.com>
Date: 2015-10-23T13:22:48Z
Add wait for template download
Refactored template section of services
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150803646
LGTM, my run was also successful:
```
[root@cs2 integration]# cat /tmp//MarvinLogs/test_internal_lb_WWSD41/results.txt
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1184.388s
OK
```
Nice catch @miguelaferreira, I assume a copy/paste error @michaelandersen? When I run it with hardware set to false it doesn't run at all:
```
[root@cs2 integration]# nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false smoke/test_internal_lb.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp//MarvinLogs//Oct_24_2015_12_12_00_4A5SNZ. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150804092
setting up a test env. will review when better rested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150604553
@michaelandersen you did not specify `required_hardware=true` are you sure the tests have actually ran?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150803722
@borisroman @DaanHoogland Can one of you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...
Posted by michaelandersen <gi...@git.apache.org>.
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150571635
ran the following test:
```
nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=../../../mct-zone1-kvm1.cfg -a tags=advanced test_internal_lb.py
```
with results:
```
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1156.295s
OK
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/971
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---