You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:28:52 UTC

[GitHub] [apisix] membphis commented on a change in pull request #4367: feat(ext-plugin): stop the runner with SIGTERM

membphis commented on a change in pull request #4367:
URL: https://github.com/apache/apisix/pull/4367#discussion_r649645257



##########
File path: apisix/cli/ops.lua
##########
@@ -361,6 +361,11 @@ Please modify "admin_key" in conf/config.yaml .
         util.die("openresty version must >=", need_ver, " current ", or_ver, "\n")
     end
 
+    local use_or_1_17 = false

Review comment:
       `use_or_1_17` is bad name




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org