You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "asafm (via GitHub)" <gi...@apache.org> on 2023/02/28 14:41:43 UTC

[GitHub] [pulsar-site] asafm opened a new pull request, #441: Fix docker compose example to work with 0 errors

asafm opened a new pull request, #441:
URL: https://github.com/apache/pulsar-site/pull/441

   # Changes
   The current docker-compose example has several drawbacks:
   - It doesn't use a fixed name; thus, when BK restarts, the cookie file stored in the data directory prevents BK from starting since it receives a different IP address hence a different name. Using "advertised" property prevents that.
   - Memory is not set hence each container takes up 2 GB heap and 1gb direct memory - almost 9 GB for a single docker-compose file, making it fail without understanding why.
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] github-actions[bot] commented on pull request #441: Fix docker compose example to work with 0 errors

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #441:
URL: https://github.com/apache/pulsar-site/pull/441#issuecomment-1448305094

   @asafm Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #441: Fix docker compose example to work with 0 errors

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #441:
URL: https://github.com/apache/pulsar-site/pull/441#issuecomment-1478826036

   Merging...
   
   Thanks for your help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun merged pull request #441: Fix docker compose example to work with 0 errors

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #441:
URL: https://github.com/apache/pulsar-site/pull/441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] asafm commented on pull request #441: Fix docker compose example to work with 0 errors

Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on PR #441:
URL: https://github.com/apache/pulsar-site/pull/441#issuecomment-1456513417

   @tisonkun Recheck please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] asafm commented on pull request #441: Fix docker compose example to work with 0 errors

Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on PR #441:
URL: https://github.com/apache/pulsar-site/pull/441#issuecomment-1448305115

   @BewareMyPower @hangc0276 Can you please double-check me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org